PDF export gives foreach error if page has no blocks on it

Bug #1971651 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
21.10
Fix Released
High
Unassigned
22.04
Fix Released
High
Unassigned
22.10
Fix Released
High
Unassigned

Bug Description

When doing an export if the page does not have a block on it there is an 'Export generated with some errors.' message

This happens when exporting a single page and full account

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review
Revision history for this message
Robert Lyon (robertl-9) wrote : Re: HTML export gives foreach error if page has no blocks on it

Will mark as High because of user experience - they will think something bad happen but actually it is a fairly safe error

description: updated
Changed in mahara:
status: New → In Progress
importance: Undecided → High
Robert Lyon (robertl-9)
no longer affects: mahara/21.04
Robert Lyon (robertl-9)
summary: - HTML export gives foreach error if page has no blocks on it
+ PDF export gives foreach error if page has no blocks on it
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/12705
Committed: https://git.mahara.org/mahara/mahara/commit/61b54aaa8bd71397d06cfaf4bf4285b4a8a87272
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 61b54aaa8bd71397d06cfaf4bf4285b4a8a87272
Author: Robert Lyon <email address hidden>
Date: Thu May 5 15:56:43 2022 +1200

Bug 1971651: Check if there are blocks in exported page

Before trying to loop on them

Change-Id: I075406249b6b8977b8dc959f5b8ff691e5916240
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "22.04_DEV" branch: https://reviews.mahara.org/c/mahara/+/12840

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/12840
Committed: https://git.mahara.org/mahara/mahara/commit/11a7b282a5e952794b3fd6d5cb4396444684ce65
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.04_DEV

commit 11a7b282a5e952794b3fd6d5cb4396444684ce65
Author: Robert Lyon <email address hidden>
Date: Thu May 5 15:56:43 2022 +1200

Bug 1971651: Check if there are blocks in exported page

Before trying to loop on them

Change-Id: I075406249b6b8977b8dc959f5b8ff691e5916240
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 61b54aaa8bd71397d06cfaf4bf4285b4a8a87272)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/12841

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/12841
Committed: https://git.mahara.org/mahara/mahara/commit/9e91287353fb830190380fbd6e6d2a962b86b9a2
Submitter: "Robert Lyon <email address hidden>"
Branch: 21.10_DEV

commit 9e91287353fb830190380fbd6e6d2a962b86b9a2
Author: Robert Lyon <email address hidden>
Date: Thu May 5 15:56:43 2022 +1200

Bug 1971651: Check if there are blocks in exported page

Before trying to loop on them

Change-Id: I075406249b6b8977b8dc959f5b8ff691e5916240
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 61b54aaa8bd71397d06cfaf4bf4285b4a8a87272)
(cherry picked from commit 11a7b282a5e952794b3fd6d5cb4396444684ce65)

no longer affects: mahara
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.