Can't access 2nd 'Show more' in block configuration with keyboard

[Kristina Hoeppner]

Only able to show more block types one time – clicking show more a second time freezes page

1. Log in as any account holder.
2. Add or edit a page.
3. Using mouse -click the + icon to add a new block.
4. Inside the block flyout use keyboard navigation to select 'Show more'. More blocks are displayed.
5. With the keyboard, click the 'Show more' button again.

Results:

- Expected: Another set of blocks is displayed.
- Actual: Nothing happens. No additional blocks are displayed even though there are more.

[Kristina Hoeppner (kris-hoeppner)]

Still need to check if this also applies to Mahara 21.10 and 21.04.

[Robert Lyon (robertl-9)]

might be the formchangechecker onchange event a it seems to be missing from 2nd button

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/13076

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13076
Committed: https://git.mahara.org/mahara/mahara/commit/e090b6b9995c94cf2dd651525a1cdfe4dbe928e1
Submitter: "Gold <email address hidden>"
Branch: main

commit e090b6b9995c94cf2dd651525a1cdfe4dbe928e1
Author: Robert Lyon <email address hidden>
Date: Tue Aug 23 16:52:34 2022 +1200

Bug 1969712: Fixing up keyCode events

Changed them to rely on our internal list - to avoid clashes with
jquery-ui baked into gridstack being different to our normal one

Change-Id: Ie58d3dba0f8039b335db461205a89dbbeb5908ac
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "22.04_DEV" branch: https://reviews.mahara.org/c/mahara/+/13144

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13144
Committed: https://git.mahara.org/mahara/mahara/commit/e6f624e7118254fb3309462f307bd6bfc327f75c
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.04_DEV

commit e6f624e7118254fb3309462f307bd6bfc327f75c
Author: Robert Lyon <email address hidden>
Date: Tue Aug 23 16:52:34 2022 +1200

Bug 1969712: Fixing up keyCode events

Changed them to rely on our internal list - to avoid clashes with
jquery-ui baked into gridstack being different to our normal one

Change-Id: Ie58d3dba0f8039b335db461205a89dbbeb5908ac
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit e090b6b9995c94cf2dd651525a1cdfe4dbe928e1)