Submissions list shows 'Account deleted' entries with link to account that is gone

[Robert Lyon]

We need to handle the entries where the person's account has been deleted.

When the submission was released before person was deleted we just need to not show the link but plain text for the 'Account deleted' in the 'Name' column.

When the submission was not released before the person was deleted we need to also remove the ability to view page / add accessor / set result / change status of the entry as it will not work as the underlying page has been deleted

[Mahara Bot (dev-mahara)]

Patch for "main" branch: https://reviews.mahara.org/12364

[Robert Lyon (robertl-9)]

I can also get this error:
[TypeError]: Argument 1 passed to Submissions\Tools\SubmissionTools::createPortfolioTitleHtml() must be of the type string, null given, called in htdocs/module/submissions/src/Tools/SubmissionTools.php on line 344 at htdocs/module/submissions/src/Tools/SubmissionTools.php:288

To replicate:

1) log in as admin user and create a group that allows submissions
2) invite a person to the group
3) log in as that person and accept invitation
4) create a collection with one page and submit that collection to the group
5) log in as admin user and go to the Share -> Submissions page - things should look correct
6) delete the person
7) go to the Share -> Submissions page - things should be now broken

[Robert Lyon (robertl-9)]

https://reviews.mahara.org/#/c/12364/

[Kristina Hoeppner (kris-hoeppner)]

We would also need to tackle what happens with archives of submissions because if a student deletes a collection, the archive should still be accessible.

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/12364
Committed: https://git.mahara.org/mahara/mahara/commit/013bfbdd803b1fa7c16887678a56c67c02af4c19
Submitter: "Robert Lyon <email address hidden>"
Branch: main

commit 013bfbdd803b1fa7c16887678a56c67c02af4c19
Author: Robert Lyon <email address hidden>
Date: Wed Jan 19 10:04:48 2022 +1300

Bug 1958297: Submission list for deleted people

Not allow actions on deleted people

Change-Id: I928fc465be44ce05ba7245f4f34158cdd7e1592b
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "22.04_DEV" branch: https://reviews.mahara.org/c/mahara/+/13031

[Mahara Bot (dev-mahara)]

Patch for "21.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/13032

[Mahara Bot (dev-mahara)]

Patch for "21.04_DEV" branch: https://reviews.mahara.org/c/mahara/+/13033

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13031
Committed: https://git.mahara.org/mahara/mahara/commit/bf8c709cbe443514cd298704e46fbe7f324c3ce8
Submitter: "Robert Lyon <email address hidden>"
Branch: 22.04_DEV

commit bf8c709cbe443514cd298704e46fbe7f324c3ce8
Author: Robert Lyon <email address hidden>
Date: Wed Jan 19 10:04:48 2022 +1300

Bug 1958297: Submission list for deleted people

Not allow actions on deleted people

Change-Id: I928fc465be44ce05ba7245f4f34158cdd7e1592b
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 013bfbdd803b1fa7c16887678a56c67c02af4c19)

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13032
Committed: https://git.mahara.org/mahara/mahara/commit/8acdf898d2d76b2a52d341c6e65acddc3ad84548
Submitter: "Robert Lyon <email address hidden>"
Branch: 21.10_DEV

commit 8acdf898d2d76b2a52d341c6e65acddc3ad84548
Author: Robert Lyon <email address hidden>
Date: Wed Jan 19 10:04:48 2022 +1300

Bug 1958297: Submission list for deleted people

Not allow actions on deleted people

Change-Id: I928fc465be44ce05ba7245f4f34158cdd7e1592b
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 013bfbdd803b1fa7c16887678a56c67c02af4c19)

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/c/mahara/+/13033
Committed: https://git.mahara.org/mahara/mahara/commit/76b24cb12094a3fb9c0e98faafb4702e65cf8531
Submitter: "Robert Lyon <email address hidden>"
Branch: 21.04_DEV

commit 76b24cb12094a3fb9c0e98faafb4702e65cf8531
Author: Robert Lyon <email address hidden>
Date: Wed Jan 19 10:04:48 2022 +1300

Bug 1958297: Submission list for deleted people

Not allow actions on deleted people

Change-Id: I928fc465be44ce05ba7245f4f34158cdd7e1592b
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 013bfbdd803b1fa7c16887678a56c67c02af4c19)