Mahara

Problems in HTML export

  1. Series 22.04
  2. Bug #1955607
Bug #1955607 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
Mahara 22.04.0
21.10
Fix Released
High
Robert Lyon
Mahara 21.10.1
22.04
Fix Released
High
Robert Lyon
Mahara 22.04.0

Bug Description

When we fixed up some issues in HTML export in https://reviews.mahara.org/#/c/11785/

We added $this->get_block_artefacts() function to return a list of artefact IDs and set them as $artefactidarray

But then we override this variable with a new list of artefact IDs

Before this change exports could sometimes fail if a block being exported contained connections to artefacts where the description contained an embedded artefact in it, eg contained text 'artefact/file/download.php?file='

After the change in patch 11785 the error stopped because the associated artefactids were not actually checked.

This patch will endeavor to fix things so both the old and new problems go away

Robert Lyon (robertl-9)
Changed in mahara:
milestone: none → 22.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/12321

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12321
Committed: https://git.mahara.org/mahara/mahara/commit/db648e22e729044226068a228aea098ee3aecf03
Submitter: Robert Lyon (<email address hidden>)
Branch: main

commit db648e22e729044226068a228aea098ee3aecf03
Author: Robert Lyon <email address hidden>
Date: Thu Dec 23 16:23:15 2021 +1300

Bug 1955607: Getting HTML export associated files to export

Without causing errors

Change-Id: Id5aad1c65b63691ad4dd73b26b3cde79a6c773ed
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.10_DEV" branch: https://reviews.mahara.org/12390

Robert Lyon (robertl-9)
no longer affects: mahara/21.04
no longer affects: mahara/20.10
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/12390
Committed: https://git.mahara.org/mahara/mahara/commit/fcb3a7882053b188c221fdca77611f8fbd0c0fce
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.10_DEV

commit fcb3a7882053b188c221fdca77611f8fbd0c0fce
Author: Robert Lyon <email address hidden>
Date: Thu Dec 23 16:23:15 2021 +1300

Bug 1955607: Getting HTML export associated files to export

Without causing errors

Change-Id: Id5aad1c65b63691ad4dd73b26b3cde79a6c773ed
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit db648e22e729044226068a228aea098ee3aecf03)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.