Mahara

webservices need to check match in lowercase at both ends

  1. Series 21.10
  2. Bug #1971639
Bug #1971639 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
Mahara 22.04.2
21.04
Fix Released
High
Unassigned
Mahara 21.04.7
21.10
Fix Released
High
Unassigned
Mahara 21.10.4
22.04
Fix Released
High
Unassigned
Mahara 22.04.2
22.10
Fix Released
High
Robert Lyon
Mahara 22.10.0

Bug Description

We check the supplied value for username or email in lowecase but we don't check our local value in lowercase too.

Normally this is not a problem as we save those values now in lowercase - but older sites may have the value in camelcase.

Follow on for Bug 1966367

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "main" branch: https://reviews.mahara.org/c/mahara/+/12704

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/12704
Committed: https://git.mahara.org/mahara/mahara/commit/2fb4d305cc81febab404131f55020c10619cedef
Submitter: "Doris Tam <email address hidden>"
Branch: main

commit 2fb4d305cc81febab404131f55020c10619cedef
Author: Robert Lyon <email address hidden>
Date: Thu May 5 11:35:32 2022 +1200

Bug 1971639: Need to check lowercase on both ends

In case older sites have entered username or email address into the
system as camelcase we need to check our value vs supplied value both
as lowercase

Change-Id: Ib605db75f16d62f53f843b966aebc41814381971
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "22.04_DEV" branch: https://reviews.mahara.org/c/mahara/+/12800

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/12800
Committed: https://git.mahara.org/mahara/mahara/commit/ade84457a8c2013f650b8ed0c68bc7f98d36bc65
Submitter: "Doris Tam <email address hidden>"
Branch: 22.04_DEV

commit ade84457a8c2013f650b8ed0c68bc7f98d36bc65
Author: Robert Lyon <email address hidden>
Date: Thu May 5 11:35:32 2022 +1200

Bug 1971639: Need to check lowercase on both ends

In case older sites have entered username or email address into the
system as camelcase we need to check our value vs supplied value both
as lowercase

Change-Id: Ib605db75f16d62f53f843b966aebc41814381971
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 2fb4d305cc81febab404131f55020c10619cedef)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.10_DEV" branch: https://reviews.mahara.org/c/mahara/+/12801

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/12801
Committed: https://git.mahara.org/mahara/mahara/commit/1c3e97e9ae7e3d169e0c36d8efd0bbc41582881a
Submitter: "Doris Tam <email address hidden>"
Branch: 21.10_DEV

commit 1c3e97e9ae7e3d169e0c36d8efd0bbc41582881a
Author: Robert Lyon <email address hidden>
Date: Thu May 5 11:35:32 2022 +1200

Bug 1971639: Need to check lowercase on both ends

In case older sites have entered username or email address into the
system as camelcase we need to check our value vs supplied value both
as lowercase

Change-Id: Ib605db75f16d62f53f843b966aebc41814381971
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 2fb4d305cc81febab404131f55020c10619cedef)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.04_DEV" branch: https://reviews.mahara.org/c/mahara/+/12802

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/c/mahara/+/12802
Committed: https://git.mahara.org/mahara/mahara/commit/17cd2e1904e2298b740f0fdb3ada356d8387a889
Submitter: "Doris Tam <email address hidden>"
Branch: 21.04_DEV

commit 17cd2e1904e2298b740f0fdb3ada356d8387a889
Author: Robert Lyon <email address hidden>
Date: Thu May 5 11:35:32 2022 +1200

Bug 1971639: Need to check lowercase on both ends

In case older sites have entered username or email address into the
system as camelcase we need to check our value vs supplied value both
as lowercase

Change-Id: Ib605db75f16d62f53f843b966aebc41814381971
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 2fb4d305cc81febab404131f55020c10619cedef)

Kristina Hoeppner (kris-hoeppner)
summary: - webservices need to check match in lowecase at both ends
+ webservices need to check match in lowercase at both ends
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.