Auto-copied template focus not on modal

Bug #1923386 reported by Doris Tam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Unassigned
21.04
Fix Released
Medium
Unassigned

Bug Description

The new functionality of Bug #1922837 causes a new bug where the auto-copied template modal is not focused on when shown.

1. Go to Pages and Collections in the Institution section
2. Make a collection with the `Current auto-copied template` switch on
3. Make another collection
4. Turn the `Current auto-copied template` switch ON
5. A modal shall pop up
6. FAIL - When I press `Enter` the configuration is not saved

The reason for this is because the focus is still on the `Save` button on the background form and not on the modal buttons.

Robert Lyon (robertl-9)
description: updated
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11777

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11777
Committed: https://git.mahara.org/mahara/mahara/commit/db85761b25bef31e6d7f933f6017933ec1ffffdb
Submitter: Lisa Seeto (<email address hidden>)
Branch: master

commit db85761b25bef31e6d7f933f6017933ec1ffffdb
Author: Robert Lyon <email address hidden>
Date: Sat May 15 08:04:48 2021 +1200

Bug 1923386: Set focus to autotemplate modal

And have tabbing within modal when it is open

Change-Id: I5807aba4287998d458c19f5aa5297a6d95d85737
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.04_STABLE" branch: https://reviews.mahara.org/11784

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11784
Committed: https://git.mahara.org/mahara/mahara/commit/5dbaf55574c1613a63d6d1ba51496e0465856e6c
Submitter: Lisa Seeto (<email address hidden>)
Branch: 21.04_STABLE

commit 5dbaf55574c1613a63d6d1ba51496e0465856e6c
Author: Robert Lyon <email address hidden>
Date: Sat May 15 08:04:48 2021 +1200

Bug 1923386: Set focus to autotemplate modal

And have tabbing within modal when it is open

Change-Id: I5807aba4287998d458c19f5aa5297a6d95d85737
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit db85761b25bef31e6d7f933f6017933ec1ffffdb)

no longer affects: mahara/21.10
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.