Can't set plan task completion date to today's date

Bug #1901256 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned
21.10
Fix Released
High
Unassigned

Bug Description

It is not possible to create a plan task with today's date as completion date because (I think) it uses midnight as time and that will have already passed.

This may need to be a general fix, i.e. when we use the date picker and there is no time displayed, we always assume it is the end of the day, e.g. date at 23:59 instead of date at 00:00.

To replicate:

1. Create a plan and a task.
2. In the date picker for 'Completion date' select today's date.
3. Save.
Expected result: The form is saved correctly.
Actual result: Error message "The completion date must be in the future." is displayed.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11408

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → In Progress
Changed in mahara:
milestone: 21.04.0 → 21.04.1
Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Confirmed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11408
Committed: https://git.mahara.org/mahara/mahara/commit/bc02d8d88b24db0de6dc84b7308acebfa7a172d6
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit bc02d8d88b24db0de6dc84b7308acebfa7a172d6
Author: Robert Lyon <email address hidden>
Date: Thu Oct 29 10:45:32 2020 +1300

Bug 1901256: Allow today's date to be used as completion date

Change-Id: Iaa7bb4ad5b0322af3efc7de4be6ed16e2ab46f3d
Signed-off-by: Robert Lyon <email address hidden>

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.