Annotation can be updated on a page

[Kristina Hoeppner]

When you add an annotation on a page, you can still update it. Whereas when you add it via the SmartEvidence page, you cannot update it there.

Annotations on pages should also not be updatable because otherwise the assessment part can get invalidated.

To replicate:

1. Activate SmartEvidence for your institution.
2. Create a collection with one page and select a SmartEvidence framework.
3. Add an annotation via the SmartEvidence overview page.

Expected and actual result: When you view the annotation again on the SmartEvidence overview page, you cannot update it.

4. Go to the page that holds the annotation and open it in 'Edit' mode.
5. Click the 'Configure' icon of the annotation.

Expected result: You cannot edit the annotation text any more.
Actual result: You can still edit it.

[Gold (gold.catalyst)]

After looking at the configuration form for an annotation it we've realised there isn't really anything there that needs to be configured. We will remove the Configure icon so access to the form is removed.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11584

[Gold (gold.catalyst)]

Testing:

Preparation:
* Create an Institution
* On the Institution setting form activate SmartEvidence
* Create a Collection and select one of the SmartEvidence framework values
* Add at least one Page to the Collection.

Testing:
* From the homepage select the Collection from the My portfolios block
* Verify you are on a SmartEvidence page
* Click a grey bullet/button below a Page you added
* Fill in the Annotation and click Save
* Check the bullet/button is now a hollow circle
* Click that again to open the annotation
* Check you cannot edit the original test of the Annotation
* Close the Annotation
* Visit the Page (click it's title from the current screen)
* Check the Annotation is on this Page
* Edit the Page
* Check that the Annotation block does not have the configuration/cog icon
* Reposition the block
* Display the page
* Check the Annotation block remains where you put it
* Edit the Page
* Drag a new Block onto the Page
* Set it as an Annotation block
* Enter the Annotation text
* Select a Standard not already being annotated
* Save the block
* Check this new Block does not have the configuration/cog icon

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11584
Committed: https://git.mahara.org/mahara/mahara/commit/690edccda265f9d5db517de599bb7262ee54ea31
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 690edccda265f9d5db517de599bb7262ee54ea31
Author: Gold <email address hidden>
Date: Fri Feb 26 12:39:08 2021 +1300

Bug 1916833 - Annotation can be updated on a page

Config gear icon removed from the Annotation blocks.
In order to still initially create these when added we needed to check
if the Block was a new instance or not. To achieve that we are now
passing the block instance into the has_instance_config() method.

BlockInstance has been extended and will set a 'new' parameter if the ID
in the constructor is 0.

AuthPlugin* classes also have the has_instance_config(). These do not
need the BlockInstance passed in.

Change-Id: Ifac69fc1d48b45c079b6f66e610776cead3dee63

[Robert Lyon (robertl-9)]

This change creates a 'breaking change' issue.

All the other blocktypes that have their own version of has_instance_config() method will need to change to has_instance_config(BlockInstance $instance)