Locked submitted pages still allow quick editing of text blocks

Bug #1926287 reported by Sam Taylor
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Doris Tam
20.10
Fix Released
High
Gold
21.04
Fix Released
High
Gold

Bug Description

This happens with portfolios submitted to both Mahara controlled groups and Moodle assignments

Replication steps:

- Create a portfolio page
- Add a text block
- Submit the page to a controlled group

Expected: The page owner cannot edit the page at all

Actual: The page owner can edit the text block when in details mode using the new 'quick edit' feature

This was tried on two separate instances of Mahara 20.10 - one submitting to a controlled group, and a client's when submitted to the Mahara assignment plugin in Moodle.

Revision history for this message
Sam Taylor (samwisefox) wrote :
Doris Tam (doristam)
Changed in mahara:
status: New → In Progress
no longer affects: mahara/20.04
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11855
Committed: https://git.mahara.org/mahara/mahara/commit/5b2947eaea0700c5f16615917bfe4e3fdd4c06ab
Submitter: Gold (<email address hidden>)
Branch: master

commit 5b2947eaea0700c5f16615917bfe4e3fdd4c06ab
Author: Doris Tam <email address hidden>
Date: Tue Jul 13 15:12:01 2021 +1200

Bug 1926287: Disallow quick edit when a page has been submitted and locked

This is on view/view.php?id=<ID>
When we have submitted a page the view/blocks.php?id=<ID> throws an access
warning instead.

Change-Id: I5d383e632937ab52c5b9dcd556d7a821a17b7a41

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "21.04_STABLE" branch: https://reviews.mahara.org/11860

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "20.10_STABLE" branch: https://reviews.mahara.org/11861

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11860
Committed: https://git.mahara.org/mahara/mahara/commit/1c23d186a5f09328ce0393f03cc1e97e4227047f
Submitter: Robert Lyon (<email address hidden>)
Branch: 21.04_STABLE

commit 1c23d186a5f09328ce0393f03cc1e97e4227047f
Author: Doris Tam <email address hidden>
Date: Tue Jul 13 15:12:01 2021 +1200

Bug 1926287: Disallow quick edit when a page has been submitted and locked

This is on view/view.php?id=<ID>
When we have submitted a page the view/blocks.php?id=<ID> throws an access
warning instead.

Change-Id: I5d383e632937ab52c5b9dcd556d7a821a17b7a41
(cherry picked from commit 5b2947eaea0700c5f16615917bfe4e3fdd4c06ab)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11861
Committed: https://git.mahara.org/mahara/mahara/commit/b731eccc2bfc09da2a86a7c784ac981243bf0086
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.10_STABLE

commit b731eccc2bfc09da2a86a7c784ac981243bf0086
Author: Doris Tam <email address hidden>
Date: Tue Jul 13 15:12:01 2021 +1200

Bug 1926287: Disallow quick edit when a page has been submitted and locked

This is on view/view.php?id=<ID>
When we have submitted a page the view/blocks.php?id=<ID> throws an access
warning instead.

Change-Id: I5d383e632937ab52c5b9dcd556d7a821a17b7a41
(cherry picked from commit 5b2947eaea0700c5f16615917bfe4e3fdd4c06ab)

no longer affects: mahara/21.10
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.