reduce block margin on gridstack

Bug #1883471 reported by Cecilia Vela Gurovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
19.10
Fix Released
Medium
Unassigned
20.04
Fix Released
Medium
Unassigned
20.10
Fix Released
Medium
Cecilia Vela Gurovic

Bug Description

There is too much bottom margin on the blocks when they are in display mode.
This could be due to the margin of the resize handlers we have on edit mode (check image attached), where we set the block size. There is no need for this margin on display since we don't have the handlers there

Revision history for this message
Cecilia Vela Gurovic (ceciliavg) wrote :
Changed in mahara:
importance: Undecided → Medium
milestone: none → 20.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11023

Revision history for this message
Robert Lyon (robertl-9) wrote :

The rendering of blocks in behat seems to be causing problems eg test/behat/features/settings/institution_tags.feature after the patch change

Revision history for this message
Lisa Seeto (lisaseeto) wrote :

In order to address the issues in comment #3 this patch was added: https://reviews.mahara.org/#/c/10985/6

Revision history for this message
Rangi Daymond (rangid) wrote :

Leap2A export file of 'whonky' display results as screen shotted in Comment#1 above.

See how they should display here https://mahara.org/view/view.php?id=132123

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10985
Committed: https://git.mahara.org/mahara/mahara/commit/7cee3babcb16a01e203fe0467b5b7d76e5b0b682
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 7cee3babcb16a01e203fe0467b5b7d76e5b0b682
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri May 22 16:34:20 2020 +1200

Bug 1883471: New behat step 'I click on blocktype'

to replace all the repeated
And I click on "Show more"

this way we don't need to know how many
of those steps to add until we find the
clocktype we want to add

Change-Id: I16305de9777d8f229c9c64eeaa6ff27c584c7e27

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11023
Committed: https://git.mahara.org/mahara/mahara/commit/35bad6d65de2ae8cc2f40eac6cc7fda377febeea
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 35bad6d65de2ae8cc2f40eac6cc7fda377febeea
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Jun 15 16:42:19 2020 +1200

Bug 1883471: reduce margin bottom in blocks

reduced the empty space at the bottom of a block by:
1. removed the height of the resize handler elements
when the view is displayed
2. reducing the height of the gridstack rows from
the default 60px to 10px

behatnotneeded

Change-Id: I4a339fca31ffe9393f98e2beb9658e8c6072bb21

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11079

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11080

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11081

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11082

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11080
Committed: https://git.mahara.org/mahara/mahara/commit/c6bb888095a75ddb5661c9e75a3f75820508dc88
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit c6bb888095a75ddb5661c9e75a3f75820508dc88
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Jun 15 16:42:19 2020 +1200

Bug 1883471: reduce margin bottom in blocks

reduced the empty space at the bottom of a block by:
1. removed the height of the resize handler elements
when the view is displayed
2. reducing the height of the gridstack rows from
the default 60px to 10px

behatnotneeded

Change-Id: I4a339fca31ffe9393f98e2beb9658e8c6072bb21

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11079
Committed: https://git.mahara.org/mahara/mahara/commit/687f3d399063ca315de99948b04be9505f5981ca
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 687f3d399063ca315de99948b04be9505f5981ca
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri May 22 16:34:20 2020 +1200

Bug 1883471: New behat step 'I click on blocktype'

to replace all the repeated
And I click on "Show more"

this way we don't need to know how many
of those steps to add until we find the
clocktype we want to add

Change-Id: I16305de9777d8f229c9c64eeaa6ff27c584c7e27
(cherry picked from commit 7cee3babcb16a01e203fe0467b5b7d76e5b0b682)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11081
Committed: https://git.mahara.org/mahara/mahara/commit/6092c888c335c678ca2885da8de38939a3103add
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit 6092c888c335c678ca2885da8de38939a3103add
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri May 22 16:34:20 2020 +1200

Bug 1883471: New behat step 'I click on blocktype'

to replace all the repeated
And I click on "Show more"

this way we don't need to know how many
of those steps to add until we find the
clocktype we want to add

Change-Id: I16305de9777d8f229c9c64eeaa6ff27c584c7e27
(cherry picked from commit 7cee3babcb16a01e203fe0467b5b7d76e5b0b682)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11082
Committed: https://git.mahara.org/mahara/mahara/commit/33c9d8b63f7a0d89e7a32fb77bf381cdaf4016fc
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit 33c9d8b63f7a0d89e7a32fb77bf381cdaf4016fc
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Jun 15 16:42:19 2020 +1200

Bug 1883471: reduce margin bottom in blocks

reduced the empty space at the bottom of a block by:
1. removed the height of the resize handler elements
when the view is displayed
2. reducing the height of the gridstack rows from
the default 60px to 10px

behatnotneeded

Change-Id: I4a339fca31ffe9393f98e2beb9658e8c6072bb21

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.10.0 → none
no longer affects: mahara
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.