The cancel link (button) on forms has an odd style once clicked

[Robert Lyon]

I noticed this issue on adding a Plan form when I clicked (and held the click) on the 'cancel' button.

In 19.10 it used to give a grey background but now it gives a dark green background

It only appears for a split second but I'm not sure if it needs to appear at all or if the style needs fixing

[Evonne Cheung (evonne)]

The split second is caused by the fact that it has the class btn-primary in it when it shouldn't. There is already an override to make background transparent, hence it's only there for a split second. Ideally this class should be removed from code, I had a look at the lib.php but realised that the btn-primary gets applied on both Save Plan and Cancel, can it just appear on Save Plan?

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/11024

[Robert Lyon (robertl-9)]

Hi Evonne,

I've added a patch https://reviews.mahara.org/#/c/11024/ that allows us to target classes to each of the save and cancel buttons via an array called 'subclass'

[Evonne Cheung (evonne)]

Checkout and looks good to me.

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11024
Committed: https://git.mahara.org/mahara/mahara/commit/0a26db1782f452afcfe026ab1098796fa0c566d2
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 0a26db1782f452afcfe026ab1098796fa0c566d2
Author: Robert Lyon <email address hidden>
Date: Mon Jun 15 14:46:01 2020 +1200

Bug 1883031: Allow targeted classes for submitcancel element

As the submitcancel element actually consists of two elements so we
will have a 'subclass' option that can target adding different classes
to each element.

Change-Id: I3efeeb937d4fecf38c3cb997fb8faea7a115b48e
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11044

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/11044
Committed: https://git.mahara.org/mahara/mahara/commit/23af296c2b8ac1bc55ebe3231dd9c51dbfe3415f
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 20.04_STABLE

commit 23af296c2b8ac1bc55ebe3231dd9c51dbfe3415f
Author: Robert Lyon <email address hidden>
Date: Mon Jun 15 14:46:01 2020 +1200

Bug 1883031: Allow targeted classes for submitcancel element

As the submitcancel element actually consists of two elements so we
will have a 'subclass' option that can target adding different classes
to each element.

Change-Id: I3efeeb937d4fecf38c3cb997fb8faea7a115b48e
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 0a26db1782f452afcfe026ab1098796fa0c566d2)