When having restricted file uploading it fails to restrict list on subsequent upload

Bug #1859127 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
19.10
Fix Released
High
Unassigned

Bug Description

To Test:

Set in your config.php:

 $cfg->validfiletypes = 'jpeg,jpg';

Then upload a file from a directory on your system contaning many types of files (inc jpg files)

On first upload you can only see a list of .jpg files
But on second upload you see all files

Robert Lyon (robertl-9)
Changed in mahara:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 20.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10709

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10709
Committed: https://git.mahara.org/mahara/mahara/commit/c5910518c2f87b3054c1a108986c99a92790fca3
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit c5910518c2f87b3054c1a108986c99a92790fca3
Author: Robert Lyon <email address hidden>
Date: Fri Jan 10 18:41:37 2020 +1300

Bug 1859127: Keep the upload restriction in play

On the subsequent file upload

behatnotneeded

Change-Id: I46aaa83a1b2ae09bfb89f5645046f1c932b7b586
Signed-off-by: Robert Lyon <email address hidden>

Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10772

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10772
Committed: https://git.mahara.org/mahara/mahara/commit/1fe7ba44f2ae3bb7f066aa062b5e5e6bd70e3e61
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit 1fe7ba44f2ae3bb7f066aa062b5e5e6bd70e3e61
Author: Robert Lyon <email address hidden>
Date: Fri Jan 10 18:41:37 2020 +1300

Bug 1859127: Keep the upload restriction in play

On the subsequent file upload

behatnotneeded

Change-Id: I46aaa83a1b2ae09bfb89f5645046f1c932b7b586
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c5910518c2f87b3054c1a108986c99a92790fca3)

Changed in mahara:
status: Fix Committed → Fix Released
no longer affects: mahara/20.04
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.