Links in a header with skin turned on shows normal link color instead of header color

Bug #1858707 reported by Kristina Hoeppner on 2020-01-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Status tracked in 20.04
19.10
Medium
Unassigned
20.04
Medium
Evonne Cheung

Bug Description

The link color has not yet been changed in the header for a skin.

It should match the header font color and links should be underlined to indicate that they are links.

See attached screenshot.

To replicate:

1. Create a skin with:
- Header background colour: #1A21F7
- Header text colour: #FA0CFA
2. Apply the skin to a page.
3. Ensure that you give your page at least one tag.
4. View the page.
Expected result: Both the person's name and the tags should be displayed in pink and underlined.
Actual result: The link colour set in the "Text" tab in the skin is used.

Rangi Daymond (rangid) wrote :

- Gerrit: https://reviews.mahara.org/#/c/10699/ Patch set 2
- Browser/s tested: desktop Chrome
- Theme: Raw

Test steps:

1. Create a skin with:
- Header background colour: #1A21F7
- Header text colour: #FA0CFA
2. Apply the skin to a page.
3. Ensure that you give your page at least one tag.
4. View the page.
Expected result: Both the person's name and the tags should be displayed in pink and underlined.
Actual result: As expected. ✔

Reviewed: https://reviews.mahara.org/10699
Committed: https://git.mahara.org/mahara/mahara/commit/25d9cdc067e837453199bb7ec76347882f1076d5
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 25d9cdc067e837453199bb7ec76347882f1076d5
Author: Evonne <email address hidden>
Date: Wed Jan 8 14:15:19 2020 +1300

Bug 1858707 Skins header link colour

Change to use the same variable as the page title, and with
set underline and on hover

behatnotneeded

Change-Id: I87ffa780f169e5251c4f064a1ab32572be4c8eb4

Reviewed: https://reviews.mahara.org/10740
Committed: https://git.mahara.org/mahara/mahara/commit/e901c1b3f7b5ff5cc88c834d718aa621e3eabe66
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit e901c1b3f7b5ff5cc88c834d718aa621e3eabe66
Author: Evonne <email address hidden>
Date: Wed Jan 8 14:15:19 2020 +1300

Bug 1858707 Skins header link colour

Change to use the same variable as the page title, and with
set underline and on hover

behatnotneeded

Change-Id: I87ffa780f169e5251c4f064a1ab32572be4c8eb4
(cherry picked from commit 25d9cdc067e837453199bb7ec76347882f1076d5)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers