"Display page" button is highlighted in edit mode when it shouldn't be

Bug #1857274 reported by Kristina Hoeppner on 2019-12-23
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Status tracked in 20.04
19.10
High
Unassigned
20.04
High
Evonne Cheung

Bug Description

Mahara 19.10+

The "Display page" button is highlighted when in edit mode, which indicates that the display mode is turned on when that is actually not the case. That is a left-over from the "Edit mode" button that we had before.

To replicate:

1. Create a page.
2. Go into edit mode.
Expected result: None of the grey buttons on the right-hand side are highlighted (the "Add" button is in the primary brand color and stands out correctly).
Actual result: The "Display page" button has a darker grey indicating that it is active.

Reviewed: https://reviews.mahara.org/10698
Committed: https://git.mahara.org/mahara/mahara/commit/b6d446de29ac854a51a65fb04b8d9dbd922c82b0
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit b6d446de29ac854a51a65fb04b8d9dbd922c82b0
Author: Evonne Cheung <email address hidden>
Date: Wed Jan 8 13:38:42 2020 +1300

Bug 1857274: Removed highlight from "Display page" button

It was highlighted in "Edit" mode, which was
confusing as the display action was not active
since you were in "Edit" mode.

Change-Id: I1ff630eec4e512e466261b10c419d1f52fd2471d
behatnotneeded: style change only

Reviewed: https://reviews.mahara.org/10701
Committed: https://git.mahara.org/mahara/mahara/commit/29f2d8c8066d7e7e957949221c7798a0816ee476
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit 29f2d8c8066d7e7e957949221c7798a0816ee476
Author: Evonne Cheung <email address hidden>
Date: Wed Jan 8 13:38:42 2020 +1300

Bug 1857274: Removed highlight from "Display page" button

It was highlighted in "Edit" mode, which was
confusing as the display action was not active
since you were in "Edit" mode.

Change-Id: I1ff630eec4e512e466261b10c419d1f52fd2471d
behatnotneeded: style change only
(cherry picked from commit b6d446de29ac854a51a65fb04b8d9dbd922c82b0)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers