gridstack - too much recursion error when translating from old layout
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
High
|
Cecilia Vela Gurovic | ||
19.10 |
Fix Released
|
High
|
Unassigned |
Bug Description
If there is an old layout page with empty rows (no blocks in that row), when translating to new gridstack layout there will be a javascript error "too much recursion". This error will make the script fail and the process of translating will never be completed.
To test:
- have a Mahara site version 19.04 or older
- make a page and set the layout to one that has more than 3 rows. It should have at least one block in row 1 and row 3. No blocks in row 2
- upgrade the site to 19.10 or newer
- go to the page and edit it
expected result: the page is translated and there a message to show the process was successful
actual result: there is a "too much recursion" error in the browsers console and the translation process is interrupted
Changed in mahara: | |
milestone: | none → 20.04.0 |
description: | updated |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
no longer affects: | mahara/20.04 |
Patch for "master" branch: https:/ /reviews. mahara. org/10677