SmartEvidence framework editor improvements

Bug #1856260 reported by Cecilia Vela Gurovic
4
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
20.04
Fix Released
Wishlist
Cecilia Vela Gurovic

Bug Description

The json editor to create and edit SmartEvidence frameworks, still has bugs that need fixing

Changed in mahara:
status: New → Confirmed
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
importance: Undecided → High
milestone: none → 20.04.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10676

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10686

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10689

Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10689
Committed: https://git.mahara.org/mahara/mahara/commit/b25ad80ecf71f011a261f7af63279f8f788da3dc
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit b25ad80ecf71f011a261f7af63279f8f788da3dc
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Dec 23 14:08:28 2019 +1300

Bug 1856260: remove 'delete all' & 'delete last' buttons

SmartEvidence editor:
in the standard section
- remove the 'delete all' and 'delete last' buttons
in the standard elements section
- remove the 'delete last' button

behatnotneeded

Change-Id: I667404d720b83e44cc3f859620b9f22252ae46cc

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10744

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10744
Committed: https://git.mahara.org/mahara/mahara/commit/a4a7a383eda05862b5d185c2e161a5a4086659b5
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit a4a7a383eda05862b5d185c2e161a5a4086659b5
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Dec 23 14:08:28 2019 +1300

Bug 1856260: remove 'delete all' & 'delete last' buttons

SmartEvidence editor:
in the standard section
- remove the 'delete all' and 'delete last' buttons
in the standard elements section
- remove the 'delete last' button

behatnotneeded

Change-Id: I667404d720b83e44cc3f859620b9f22252ae46cc
(cherry picked from commit b25ad80ecf71f011a261f7af63279f8f788da3dc)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10745

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10745
Committed: https://git.mahara.org/mahara/mahara/commit/8684443ebf19c2ddda4baeecf06a6870926744a9
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.04_STABLE

commit 8684443ebf19c2ddda4baeecf06a6870926744a9
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Dec 23 14:08:28 2019 +1300

Bug 1856260: remove 'delete all' & 'delete last' buttons

SmartEvidence editor:
in the standard section
- remove the 'delete all' and 'delete last' buttons
in the standard elements section
- remove the 'delete last' button

behatnotneeded

Change-Id: I667404d720b83e44cc3f859620b9f22252ae46cc
(cherry picked from commit b25ad80ecf71f011a261f7af63279f8f788da3dc)
(cherry picked from commit a4a7a383eda05862b5d185c2e161a5a4086659b5)

no longer affects: mahara/19.04
no longer affects: mahara/19.10
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10686
Committed: https://git.mahara.org/mahara/mahara/commit/420990bfee1e50fcfc878f4067c59e9fa27f50a7
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 420990bfee1e50fcfc878f4067c59e9fa27f50a7
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Dec 20 15:31:30 2019 +1300

Bug 1856260: update element count when deleting a standard

so it will add the correct number at the end of a
standard element when adding a new one

behatnotneeded

Change-Id: I24e2b0a0d729b56efd6f271c4c609dab53322846

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10676
Committed: https://git.mahara.org/mahara/mahara/commit/b8d26c1fe073b7dc4c0f9f7c8ea8489308b879b8
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit b8d26c1fe073b7dc4c0f9f7c8ea8489308b879b8
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Dec 11 16:51:56 2019 +1300

Bug 1856260: Delete elements when deleting the parent (standard & element)

- When deleting a standard, then delete all the elements that have it as parent
- When deleting an element, then delete all the elements that have it as parent
- it works when multiple elements depend on a deleted parent
- it gets called recursively: if an element was deleted because its parent
was deleted, then delete all the elements also depending on it

- The message displayed when removing one node of the form is hardcoded in the library
I've changed to
"Are you sure you want to remove this item? If there is any other item depending on it, it will be removed too."
since it's had to see if we are deleting a standard or a standard element.

behatnotneeded
Change-Id: Ifc7d7e0e491c398262bd603ea8f348770a952916

tags: added: nominatedfeature
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.04.0 → none
status: Fix Committed → Fix Released
no longer affects: mahara
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11582

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.