Problems with restricting profile access

[Robert Lyon]

When you have
- the "Profile access for all registered users" setting in Admin -> Configure site -> Site options -> User settings turned off
- three users in no institution (Users A, B and C)
- three users in in Institution A (Users D, E and F)
- a user in Institution B (User G)

- and I log in as User A and share your profile page with User B only - removing any 'registered users' access rules
- and I log in as User D and share your profile page with User B only - removing any 'registered users' access rules

- if you then login as user B you are able to see the full profile page of User A and of User D

In v18.10
- if you log in as User C you can't see the full profile page of User A or of User D - you see
"Full access to this user profile is restricted."
- if you log in as User E you can't see the full profile page of User A - you see
"Full access to this user profile is restricted."
  - you can see the full profile page of User D as you are in the same institution
- if you log in as User G you can't see the full profile page of User A or of User D - you see
"Full access to this user profile is restricted."

In v19.10
- if you log in as User C you can see the full profile page of User A
*** problem one ***
- if you view the profile page of User D - you see "Full access to this user profile is restricted." but you also see a bunch of errors
*** problem two ***

- if you log in as User E you can't see the full profile page of User A - you see
"Full access to this user profile is restricted." but you also see a bunch of errors
*** problem two again? ***
  - you can see the full profile page of User D as you are in the same institution

- if you log in as User G you can't see the full profile page of User A or of User D - you see
"Full access to this user profile is restricted." but you also see a bunch of errors for both
*** problem two again? ***

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10660

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10660
Committed: https://git.mahara.org/mahara/mahara/commit/39be1d1d4eb3f1024a52dd9eaa86fed737336c33
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 39be1d1d4eb3f1024a52dd9eaa86fed737336c33
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Dec 9 14:41:14 2019 +1300

Bug 1855614: added missing check for isolated institution property

behatnotneeded

Change-Id: Ic7d7a0a3ac8ae154ffdcd020b051577ad86d4cdb

[Mahara Bot (dev-mahara)]

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10667

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10667
Committed: https://git.mahara.org/mahara/mahara/commit/f3d000853e64903d014239cdc28457759f44969d
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit f3d000853e64903d014239cdc28457759f44969d
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Dec 9 14:41:14 2019 +1300

Bug 1855614: added missing check for isolated institution property

behatnotneeded

Change-Id: Ic7d7a0a3ac8ae154ffdcd020b051577ad86d4cdb
(cherry picked from commit 39be1d1d4eb3f1024a52dd9eaa86fed737336c33)

[Mahara Bot (dev-mahara)]

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10668

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10668
Committed: https://git.mahara.org/mahara/mahara/commit/0e1e9dba1690c631ba12bc0d2910548f84bf9189
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 0e1e9dba1690c631ba12bc0d2910548f84bf9189
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Dec 9 14:41:14 2019 +1300

Bug 1855614: added missing check for isolated institution property

behatnotneeded

Change-Id: Ic7d7a0a3ac8ae154ffdcd020b051577ad86d4cdb
(cherry picked from commit 39be1d1d4eb3f1024a52dd9eaa86fed737336c33)
(cherry picked from commit f3d000853e64903d014239cdc28457759f44969d)