'Display page' button should not be displayed for site templates

Bug #1852522 reported by Cecilia Vela Gurovic on 2019-11-14
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Status tracked in 20.04
19.10
High
Unassigned
20.04
High
Unassigned

Bug Description

An error message is displayed when a site admin user tries to display a site template (Profile page, Dashboard page and group homepage templates)

Error message:
[WAR] 9f (lib/web.php:3490) redirect() should be called with either /[something] for local redirects or http[something] for absolute redirects
Call stack (most recent first):

    redirect("") at /home/ceciliavg/maharacode/mahara/htdocs/view/view.php:126

To reproduce:
-go to Configure site -> Pages & Collections
-click on any of these 3 site templates: Profile page, Dashboard page or group homepage templates
the page is displayed in view mode
- Click on the 'Display page' button from the top right floating menu

Expected result: The templates are not supposed to be shown in display mode. The 'Display page' button should not even be present for these pages
Actual result: The 'Display page' button is displayed and clicking on it redirects to a page with an error message

Reviewed: https://reviews.mahara.org/10609
Committed: https://git.mahara.org/mahara/mahara/commit/527fefd9cc373e75865b5e23bbe67c97d704f9a3
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 527fefd9cc373e75865b5e23bbe67c97d704f9a3
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Nov 14 16:04:20 2019 +1300

Bug 1852522: don't show 'Display page' for site templates

behatnotneeded

Change-Id: Id06668950d8b301d077142fd1c3200bd8ca46223

Reviewed: https://reviews.mahara.org/10614
Committed: https://git.mahara.org/mahara/mahara/commit/2918a6b6caa05df86eb304b63f43d0b16ea3246c
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit 2918a6b6caa05df86eb304b63f43d0b16ea3246c
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Nov 14 16:04:20 2019 +1300

Bug 1852522: don't show 'Display page' for site templates

behatnotneeded

Change-Id: Id06668950d8b301d077142fd1c3200bd8ca46223
(cherry picked from commit 527fefd9cc373e75865b5e23bbe67c97d704f9a3)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers