Mahara

Nav menu missing import / export items

Bug #1852020 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Robert Lyon
Mahara 20.04.0
18.10
Fix Released
High
Unassigned
Mahara 18.10.4
19.04
Fix Released
High
Unassigned
Mahara 19.04.3
19.10
Fix Released
High
Unassigned
Mahara 19.10.1

Bug Description

Because we don't show those menu items when on mobile it means if a user hits site with mobile first the menu is cached with those item not there.

We need to separate the cache for mobile menu from desktop menu

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10587

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: New → In Progress
importance: Undecided → High
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10587
Committed: https://git.mahara.org/mahara/mahara/commit/a1ad56851b3316da2a0bfb0cc70d16650958caa6
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit a1ad56851b3316da2a0bfb0cc70d16650958caa6
Author: Robert Lyon <email address hidden>
Date: Mon Nov 11 09:28:23 2019 +1300

Bug 1852020: Cache nav menu for mobile different to desktop

As the menus are slightly different - the mobile one doesn't have
import/export menu items

behat not needed

Change-Id: Ia84f68cbe12a5a6555b7e2e378b44b41875b9328
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10593

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10594

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/10595

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10595
Committed: https://git.mahara.org/mahara/mahara/commit/9d28392d1b2a4116285e4e6b2245a5cc59defa83
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit 9d28392d1b2a4116285e4e6b2245a5cc59defa83
Author: Robert Lyon <email address hidden>
Date: Mon Nov 11 09:28:23 2019 +1300

Bug 1852020: Cache nav menu for mobile different to desktop

As the menus are slightly different - the mobile one doesn't have
import/export menu items

behat not needed

Change-Id: Ia84f68cbe12a5a6555b7e2e378b44b41875b9328
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit a1ad56851b3316da2a0bfb0cc70d16650958caa6)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10594
Committed: https://git.mahara.org/mahara/mahara/commit/b79d992b586723d3a042ac25ff4f7f216cf0af0c
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit b79d992b586723d3a042ac25ff4f7f216cf0af0c
Author: Robert Lyon <email address hidden>
Date: Mon Nov 11 09:28:23 2019 +1300

Bug 1852020: Cache nav menu for mobile different to desktop

As the menus are slightly different - the mobile one doesn't have
import/export menu items

behat not needed

Change-Id: Ia84f68cbe12a5a6555b7e2e378b44b41875b9328
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit a1ad56851b3316da2a0bfb0cc70d16650958caa6)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10593
Committed: https://git.mahara.org/mahara/mahara/commit/c9c25ed7d5026b999bc29e4a9dfe8bfc9242ac14
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit c9c25ed7d5026b999bc29e4a9dfe8bfc9242ac14
Author: Robert Lyon <email address hidden>
Date: Mon Nov 11 09:28:23 2019 +1300

Bug 1852020: Cache nav menu for mobile different to desktop

As the menus are slightly different - the mobile one doesn't have
import/export menu items

behat not needed

Change-Id: Ia84f68cbe12a5a6555b7e2e378b44b41875b9328
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit a1ad56851b3316da2a0bfb0cc70d16650958caa6)

Cecilia Vela Gurovic (ceciliavg)
no longer affects: mahara/20.04
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.