Consolidate CSS for skins to work better with new header and details mode

Bug #1850859 reported by Kristina Hoeppner on 2019-10-31
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Status tracked in 20.04
19.10
High
Unassigned
20.04
High
Evonne Cheung

Bug Description

In bug 1847005 a number of changes were made to get skin colors work better with the new header and details mode.

One thing that is missing is that "by" and "Tags" are also in the same colour as the header text.

The line below a collection title should also be in the heading font as it is not visible on dark backgrounds.

Evonne suggested removing / changing some more CSS so that the new styles work better in skins.

Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10606

Reviewed: https://reviews.mahara.org/10550
Committed: https://git.mahara.org/mahara/mahara/commit/ed885258e285d4e346ae33ff74b67de18368a0cb
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit ed885258e285d4e346ae33ff74b67de18368a0cb
Author: Evonne <email address hidden>
Date: Fri Nov 1 12:29:08 2019 +1300

Bug #1850859 skins theming fixes

- removed redundant styles
- added in styles to make sure all elements and child within that
is capable of color changing will be workable

behatnotneeded

Change-Id: I538e317b44a103cd0dcd48cfa605754711c83063

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10606
Committed: https://git.mahara.org/mahara/mahara/commit/7b77d3659adeb0b09f7ea3a1683c75d104447fc7
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 7b77d3659adeb0b09f7ea3a1683c75d104447fc7
Author: Lisa Seeto <email address hidden>
Date: Thu Nov 14 13:21:01 2019 +1300

Bug 1850859: consolidate css for skins to work better with new header details mode

- #viewh1 was targeting page titles of page's using a skin with a
bold font-weight. There were a few places using the #viewh1 but none of them seemed
to actually be in bold. Have removed it for now to fix page titles.

- Also added the link / link hover styles to the tags / page owner
links so they can be controlled the same way as page links

behatnotneeded

Change-Id: I945584426798aa5835452dc885816c60c377ce34
Signed-off-by: Lisa Seeto <email address hidden>

Reviewed: https://reviews.mahara.org/10611
Committed: https://git.mahara.org/mahara/mahara/commit/926c4f78d11866a6025bff0a790cd8fea8aa881f
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit 926c4f78d11866a6025bff0a790cd8fea8aa881f
Author: Evonne <email address hidden>
Date: Fri Nov 1 12:29:08 2019 +1300

Bug #1850859 skins theming fixes

- removed redundant styles
- added in styles to make sure all elements and child within that
is capable of color changing will be workable

behatnotneeded

Change-Id: I538e317b44a103cd0dcd48cfa605754711c83063
(cherry picked from commit ed885258e285d4e346ae33ff74b67de18368a0cb)

Reviewed: https://reviews.mahara.org/10612
Committed: https://git.mahara.org/mahara/mahara/commit/e89c416d1d651794ae06d233d6343989d1404389
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit e89c416d1d651794ae06d233d6343989d1404389
Author: Lisa Seeto <email address hidden>
Date: Thu Nov 14 13:21:01 2019 +1300

Bug 1850859: consolidate css for skins to work better with new header details mode

- #viewh1 was targeting page titles of page's using a skin with a
bold font-weight. There were a few places using the #viewh1 but none of them seemed
to actually be in bold. Have removed it for now to fix page titles.

- Also added the link / link hover styles to the tags / page owner
links so they can be controlled the same way as page links

behatnotneeded

Change-Id: I945584426798aa5835452dc885816c60c377ce34
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit 7b77d3659adeb0b09f7ea3a1683c75d104447fc7)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers