Need a isGridstackRendering flag

Bug #1849771 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Cecilia Vela Gurovic
19.10
Fix Released
High
Unassigned
20.04
Fix Released
High
Cecilia Vela Gurovic

Bug Description

For behat we have a function isMaharaPageReady() and this checks a bunch of things to make sure that the page is ready for behat to test - it includes checking pieforms have finished rendering, modals finished loading, tinymces finished setup etc

I think we also need to have a: isGridstackRendering flag to make sure that any gridstack adjustments of the page have finished also

Robert Lyon (robertl-9)
Changed in mahara:
status: New → Confirmed
importance: Undecided → High
Changed in mahara:
milestone: none → 20.04.0
Changed in mahara:
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10567

Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10567
Committed: https://git.mahara.org/mahara/mahara/commit/d45fe03c46cf339abdf7555ed6691efd596221cc
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit d45fe03c46cf339abdf7555ed6691efd596221cc
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Nov 6 14:49:01 2019 +1300

Bug 1849771: adding isGridstackRendering flag

to indicate the gridstack has finished loading
when running the behat tests

behatnotneeded

Change-Id: I2ab9f8962aa651c761175375047ee8d1ab1d2fe0

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10613

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10613
Committed: https://git.mahara.org/mahara/mahara/commit/c55a7ae824a11b4d40714b71d9e926bf2bc91c32
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit c55a7ae824a11b4d40714b71d9e926bf2bc91c32
Author: Cecilia Vela Gurovic <email address hidden>
Date: Wed Nov 6 14:49:01 2019 +1300

Bug 1849771: adding isGridstackRendering flag

to indicate the gridstack has finished loading
when running the behat tests

behatnotneeded

Change-Id: I2ab9f8962aa651c761175375047ee8d1ab1d2fe0
(cherry picked from commit d45fe03c46cf339abdf7555ed6691efd596221cc)

Changed in mahara:
status: Fix Committed → Fix Released
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.04.0 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.