Mahara

sign off block height on gridstack

  1. Series 19.10
  2. Bug #1891949
Bug #1891949 reported by Cecilia Vela Gurovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
19.10
Fix Released
Medium
Unassigned
Mahara 19.10.5
20.04
Fix Released
Medium
Unassigned
Mahara 20.04.2
20.10
Fix Released
Medium
Cecilia Vela Gurovic
Mahara 20.10.0

Bug Description

The sign off block content is very different when editing the page from when viewing the page. This makes the block have a lot of extra space when viewing the page. We can make the height be predefined for viewsing since it will always have the same content, it can only have
Sign off / Verify lines
or
Sign off alone

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: New → Confirmed
milestone: none → 20.10.0
importance: Undecided → Medium
Cecilia Vela Gurovic (ceciliavg)
no longer affects: mahara/19.04
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11161

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11161
Committed: https://git.mahara.org/mahara/mahara/commit/db35d4e8cc79bee98933f87cabad83f8014acc07
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit db35d4e8cc79bee98933f87cabad83f8014acc07
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Aug 21 09:17:31 2020 +1200

Bug 1891949: don't use saved height for signoff blocks

and add a function to make it possible for other blocks
that have different contents in edit/view modes
to ignore the height and let the gridstack library resize

behatnotneeded

Change-Id: I471e35d3881d7f3654cd508f7de31ebfdedfbc5c

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11166

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11167

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11167
Committed: https://git.mahara.org/mahara/mahara/commit/70662bdafd2d5703ea621cccd7b7490b4b46b5a2
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit 70662bdafd2d5703ea621cccd7b7490b4b46b5a2
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Aug 21 09:17:31 2020 +1200

Bug 1891949: don't use saved height for signoff blocks

and add a function to make it possible for other blocks
that have different contents in edit/view modes
to ignore the height and let the gridstack library resize

behatnotneeded

Change-Id: I471e35d3881d7f3654cd508f7de31ebfdedfbc5c
(cherry picked from commit db35d4e8cc79bee98933f87cabad83f8014acc07)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11166
Committed: https://git.mahara.org/mahara/mahara/commit/37ee3bfb36f44c63dde2a2a0ae2b30661feb00b1
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 37ee3bfb36f44c63dde2a2a0ae2b30661feb00b1
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Aug 21 09:17:31 2020 +1200

Bug 1891949: don't use saved height for signoff blocks

and add a function to make it possible for other blocks
that have different contents in edit/view modes
to ignore the height and let the gridstack library resize

behatnotneeded

Change-Id: I471e35d3881d7f3654cd508f7de31ebfdedfbc5c
(cherry picked from commit db35d4e8cc79bee98933f87cabad83f8014acc07)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.10.0 → none
Kristina Hoeppner (kris-hoeppner)
no longer affects: mahara
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.