Add comments and details block headers not changing colour when active

Bug #1867707 reported by Lisa Seeto on 2020-03-17
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Status tracked in 20.04
19.10
Medium
Unassigned
20.04
Medium
Evonne Cheung

Bug Description

When a block on a page is viewed in "details" mode the block comments and details header can be seen. When selected to open the associated modal the background colour of the bar of the heading should change colour to indicate the block that was selected.

To reproduce:
1. Log in as any person and create a page
2. Create an image block and display the page.
3. Select "Details" mode to turn it on and view the block detail headers
4. Click on the header to open the details modal and look at the block detail header on the page
Expected result:
The active block header background colour has changed.
Actual result:
The block header header background colour has not updated (remains black in raw).

Lisa Seeto (lisaseeto) wrote :
Lisa Seeto (lisaseeto) on 2020-03-18
Changed in mahara:
status: New → In Progress

Reviewed: https://reviews.mahara.org/10827
Committed: https://git.mahara.org/mahara/mahara/commit/01cab2e421a2ea35935fdf5c849a8d6b5d55d321
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 01cab2e421a2ea35935fdf5c849a8d6b5d55d321
Author: Evonne <email address hidden>
Date: Wed Mar 18 14:20:16 2020 +1300

Bug 1867707 Add comments and details block header active state

Moved styles to the right path for active states to been seen when
a block's add comments/details opens up a modal.

- added in more specific target to folder_render_in_modal to prevent
the wrong event being called on open_modal func

behatnotneeded

Change-Id: I78d647e44f938de432a4757b309bca7caae3adcb

Robert Lyon (robertl-9) on 2020-03-23
Changed in mahara:
milestone: none → 20.04.0
status: In Progress → Fix Committed

Reviewed: https://reviews.mahara.org/10836
Committed: https://git.mahara.org/mahara/mahara/commit/8bca2f5b19db1f48c1656516ad44121eda11d01b
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit 8bca2f5b19db1f48c1656516ad44121eda11d01b
Author: Evonne <email address hidden>
Date: Wed Mar 18 14:20:16 2020 +1300

Bug 1867707 Add comments and details block header active state

Moved styles to the right path for active states to been seen when
a block's add comments/details opens up a modal.

- added in more specific target to folder_render_in_modal to prevent
the wrong event being called on open_modal func

behatnotneeded

Change-Id: I78d647e44f938de432a4757b309bca7caae3adcb
(cherry picked from commit 01cab2e421a2ea35935fdf5c849a8d6b5d55d321)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers