Stop displaying an email profile field as one of the normal fields

Bug #1858512 reported by Robert Lyon on 2020-01-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Status tracked in 20.04
18.10
High
Unassigned
19.04
High
Unassigned
19.10
High
Unassigned
20.04
High
Unassigned

Bug Description

The profile block treats the email field as special and only allows one email to be displayed.
However if the artefactids for the normal fields (eg firstname) ends up containing an id for an email field it causes problems as you cannot unset it from displaying.

I'm yet to work out how the array can end up with an email id but I have seen client sites where this has happened.

To avoid displaying the extra email artefacts I've created the following patch
https://reviews.mahara.org/#/c/10631/1

Robert Lyon (robertl-9) on 2020-01-07
Changed in mahara:
importance: Undecided → High
status: New → In Progress
milestone: none → 20.04.0

copied from a comment in the patch:

I've found a way to replicate:

    have a user with it's email
    login as this user
    create a view with a 'Profile information', select the email and save
    add a new email address through Profile -> contact information and save
    validate the new email address and select it to be the primary email address for the account
    remove the old email address
    go back to the view with the Profile information block
    result:
    Debug message "Artefact with id X not found"

Reviewed: https://reviews.mahara.org/10631
Committed: https://git.mahara.org/mahara/mahara/commit/c2ab187578b2db4961a80409ac3ddfceb9b3300e
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit c2ab187578b2db4961a80409ac3ddfceb9b3300e
Author: Robert Lyon <email address hidden>
Date: Tue Dec 3 09:46:35 2019 +1300

Bug 1858512: Able to remove email for profilefield

If it gets saved as one of the 'artefactids' values

@TODO - work out how it can get saved as this way
- suspect it is an issue with template copying

Change-Id: Icd7cb73b6a9a9eead0f6c54b2e09b2804eda8ce4
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10798

Reviewed: https://reviews.mahara.org/10798
Committed: https://git.mahara.org/mahara/mahara/commit/2e8fa553dadf00b20ceea9f71363cb26982364b9
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.04_STABLE

commit 2e8fa553dadf00b20ceea9f71363cb26982364b9
Author: Robert Lyon <email address hidden>
Date: Tue Dec 3 09:46:35 2019 +1300

Bug 1858512: Able to remove email for profilefield

If it gets saved as one of the 'artefactids' values

@TODO - work out how it can get saved as this way
- suspect it is an issue with template copying

Change-Id: Icd7cb73b6a9a9eead0f6c54b2e09b2804eda8ce4
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c2ab187578b2db4961a80409ac3ddfceb9b3300e)

Reviewed: https://reviews.mahara.org/10799
Committed: https://git.mahara.org/mahara/mahara/commit/54db0537cae272cf6316d187805003070194b598
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.10_STABLE

commit 54db0537cae272cf6316d187805003070194b598
Author: Robert Lyon <email address hidden>
Date: Tue Dec 3 09:46:35 2019 +1300

Bug 1858512: Able to remove email for profilefield

If it gets saved as one of the 'artefactids' values

@TODO - work out how it can get saved as this way
- suspect it is an issue with template copying

Change-Id: Icd7cb73b6a9a9eead0f6c54b2e09b2804eda8ce4
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c2ab187578b2db4961a80409ac3ddfceb9b3300e)
(cherry picked from commit 2e8fa553dadf00b20ceea9f71363cb26982364b9)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10797
Committed: https://git.mahara.org/mahara/mahara/commit/7f447549bad6e6688a113a7903c61646b46611f8
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit 7f447549bad6e6688a113a7903c61646b46611f8
Author: Robert Lyon <email address hidden>
Date: Tue Dec 3 09:46:35 2019 +1300

Bug 1858512: Able to remove email for profilefield

If it gets saved as one of the 'artefactids' values

@TODO - work out how it can get saved as this way
- suspect it is an issue with template copying

Change-Id: Icd7cb73b6a9a9eead0f6c54b2e09b2804eda8ce4
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c2ab187578b2db4961a80409ac3ddfceb9b3300e)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers