Error when alterting the block placeholder name before choosing block type

Bug #1851288 reported by Robert Lyon on 2019-11-04
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Status tracked in 20.04
19.10
High
Unassigned
20.04
High
Unassigned

Bug Description

If I add a block to the page and change the title to:

Intro 1.5

And then choose the block type, eg Image
I get an error on the screen

Invalid page control action: id_34_new_1_blocktype_image_title_Intro%201_5

I believe this is caused by the . in the title name

Robert Lyon (robertl-9) wrote :

Yes the php turns the dot char into underscore for an array key

Steven (stevens-q) wrote :

Commit hash: f4360be786ef2ffa3e0debfb4da32a235afcf98b
Environment tested: Master
Browser tested: Chrome
Theme used: Raw

PRECONDITIONS:
------------------------
1)Mahara user exists (No roles)

TEST STEPS:
------------------------
1) User log in as Mahara user (No roles)
2) Create a portfolio page
3) Drag and drop a block to the page
4) Enter "Intro 1.5" in the Block title field and select Image block from the content types
5) Verify that the block is displayed with no errors
6) Verify that the following error message is not displayed:
  — "Invalid page control action: id_93_new_1_blocktype_image_title_Place%20Intro%201_5"

Catalyst QA Approved ✔

Reviewed: https://reviews.mahara.org/10563
Committed: https://git.mahara.org/mahara/mahara/commit/f4360be786ef2ffa3e0debfb4da32a235afcf98b
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit f4360be786ef2ffa3e0debfb4da32a235afcf98b
Author: Robert Lyon <email address hidden>
Date: Tue Nov 5 09:12:10 2019 +1300

Bug 1851288: URL encode the . char in block title

Along with the other special chars as we use it as an array key and
PHP changes . to _

behatnotneeded

Change-Id: I22125a539bb205b8e1bc036c4ceee995d19ffb73
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/10579
Committed: https://git.mahara.org/mahara/mahara/commit/bab0f2fcdf61db7e91b86dd97f5b98f078b0a010
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit bab0f2fcdf61db7e91b86dd97f5b98f078b0a010
Author: Robert Lyon <email address hidden>
Date: Tue Nov 5 09:12:10 2019 +1300

Bug 1851288: URL encode the . char in block title

Along with the other special chars as we use it as an array key and
PHP changes . to _

behatnotneeded

Change-Id: I22125a539bb205b8e1bc036c4ceee995d19ffb73
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit f4360be786ef2ffa3e0debfb4da32a235afcf98b)

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers