Select2 accessibility for labelling and removing tags

Bug #1843847 reported by Rebecca Blundell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Rebecca Blundell
20.04
Fix Released
High
Rebecca Blundell

Bug Description

In upgrading select2 to 4.0.9, I have not made the following changes:

* Add label to "Remove tag" button
* Adding ability to remove tag via 'enter' key if one is focused on the 'x' of a tag (commit 5ec92cddcf24fca18fdb1b24707216a5ea24bde8) - added but doesn't seem to work :(

It also seemed to not be working in the current code.

We need to find a version in which this is working and then copy the code over or just make the changes again, whichever is easier.

For clarity, the issue is that if you make tags as a keyboard user, the x (remove) button is not accessible via tab or arrow keys. Also there is no label on that button so that a screen reader would not be able to identify what the remove button was.

Tags: regression
tags: added: regression
Changed in mahara:
status: New → Confirmed
importance: Undecided → High
milestone: none → 19.10.0
Changed in mahara:
assignee: nobody → Rebecca Blundell (rjb-dev)
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10352

Changed in mahara:
milestone: 19.10.0 → 19.10.1
no longer affects: mahara/19.10
Revision history for this message
Lisa Seeto (lisaseeto) wrote :

Looks like it was merged in the parent patch here https://reviews.mahara.org/#/c/10336/4

Changed in mahara:
status: Fix Committed → Fix Released
Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.04.0 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.