Should not display message link when messages set to 'nobody' and isolated institutions set

[Robert Lyon]

If a user sets their message preference to 'nobody' then we shouldn't
display the message icon on their profile page

To test:

Have some users in the same institution and have one of them set their account preference for messages to nobody
Turn on isolated institutions via $cfg->isolatedinstitutions = true; in config.php
Log in as another member of the institution and view the profile pages of other users - the one with 'nobody' for message preference should not show the message icon/link

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10178

[Steven (stevens-q)]

Commit hash: 06112d9949a52a500f396f30d488acb0e0d96d23
Environment tested: Master
Browser tested: Chrome
Theme used: Raw

PRECONDITIONS:
------------------------
1) Isolated institutions via $cfg->isolatedinstitutions = true; in config.php
2) Institution exists (Instone)
3) Users exist that are menbers of instone as follows
   a) User1 - has Messages from other users = Do not allow anyone to send me messages
   b) User2 - has Messages from other users = Allow anyone to send me messages

TEST STEPS:
------------------------
1) Log in as User2
2) Browse to Engage > People
3) Click on User1 to view their Profile page
4) Verify that the message icon/link is not displayed ✔

Catalyst QA Approved ✔

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10182

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10178
Committed: https://git.mahara.org/mahara/mahara/commit/e81ad261d54c386ae9267b59d23373e13bfa8fd9
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit e81ad261d54c386ae9267b59d23373e13bfa8fd9
Author: Robert Lyon <email address hidden>
Date: Thu Jul 18 11:41:31 2019 +1200

Bug 1836977: Isolated institutions to respect 'nobody' message setting

if a user sets their message preference to 'nobody' then we shouldn't
display the message icon

behatnotneeded

Change-Id: Ie60f964ffaa4359f58c69769a7814d058179533b
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10190

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10190
Committed: https://git.mahara.org/mahara/mahara/commit/b065250f2d1b0811bcc1f7bc5c91b223f943915f
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.04_STABLE

commit b065250f2d1b0811bcc1f7bc5c91b223f943915f
Author: Robert Lyon <email address hidden>
Date: Thu Jul 18 11:41:31 2019 +1200

Bug 1836977: Isolated institutions to respect 'nobody' message setting

if a user sets their message preference to 'nobody' then we shouldn't
display the message icon

behatnotneeded

Change-Id: Ie60f964ffaa4359f58c69769a7814d058179533b
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit e81ad261d54c386ae9267b59d23373e13bfa8fd9)