Profile picture generates error when uploaded to Image Gallery

[Ghada El-Zoghbi]

Mahara: 19.04.0
OS: Linux 16.04
DB: Postgres
Browser: FF

When a profile picture is uploaded to an image gallery, an error is generated in the console and the image gallery hangs.

To replicate:

• Upload a profile picture to a user account - this will add the image to the files collection under images
• In a page, add an image gallery with settings:
- Image selection = Choose individual images to display
- Select the 'Uploaded profile picture' under the images directory
- Save

• Result: Console error

jQuery.Deferred exception: upload_max_filesize is not defined http://mahara/artefact/file/js/filedropzone.js?v=8112:36:9
l@http:/mahara/js/jquery/jquery.js?v=8112:2:29375
a/</c< http://mahara/js/jquery/jquery.js?v=8112:2:29677
undefined jquery.js:2:30930

ReferenceError: upload_max_filesize is not defined

• Expected result: image is saved to gallery

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10177

[Steven (stevens-q)]

Commit hash: 99c885321e66eb386f744b0c01d0287a16ce89b6
Environment tested: Master
Browser tested: Chrome
Theme used: Raw

PRECONDITIONS:
------------------------
1) Mahara User3 exists (no roles)
2) User has a few image files in their profile already

TEST STEPS:
------------------------
1) Log in as Mahara User3
2) Browse to User menu > Profile pictures
3) Upload an image from your local files to your profile picture
4) Set it as your default
5) Verify that the image is displayed as your user profile image ✔
6) Verify that there are no Console errors ✔
7) Create a portfolio page
8) Add an image gallery block to the page
9) In the modal window that opens select The following
   a) Image selection = "Choose individual images to display"
   b) Select a few images
10) Open the folder labeled "Images"
11) Select the Uploaded profile picture in the previous steps
12) Press save
13) Verify that the image gallery block contains all the images you selected ✔
14) Verify that there are no Console errors ✔
15) Add an image block to the page
16) Open the folder labeled "Images"
17) Select the Uploaded profile picture in the previous steps
18) Press save
19) Verify that the image block contains the image you selected ✔
20) Verify that there are no Console errors ✔

Catalyst QA Approved ✔

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10177
Committed: https://git.mahara.org/mahara/mahara/commit/99c885321e66eb386f744b0c01d0287a16ce89b6
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 99c885321e66eb386f744b0c01d0287a16ce89b6
Author: anupamadharmajan <email address hidden>
Date: Wed Jul 17 17:46:00 2019 +1000

Bug 1834470: Profile picture generates error when uploaded to Image Gallery.

Fixed undefined upload_max_filesize variable and artefact type mismatch for profileicon

Sponsored by The Australian National University

behatnotneeded

Change-Id: I2014806ffbf8d36311d857f43de359e3f477dc58

[Mahara Bot (dev-mahara)]

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10193

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10193
Committed: https://git.mahara.org/mahara/mahara/commit/0d7bd06c4298d07c0204d01caecc4dacd57c6093
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 0d7bd06c4298d07c0204d01caecc4dacd57c6093
Author: anupamadharmajan <email address hidden>
Date: Wed Jul 17 17:46:00 2019 +1000

Bug 1834470: Profile picture generates error when uploaded to Image Gallery.

Fixed undefined upload_max_filesize variable and artefact type mismatch for profileicon

Sponsored by The Australian National University

behatnotneeded

Change-Id: I2014806ffbf8d36311d857f43de359e3f477dc58
(cherry picked from commit 99c885321e66eb386f744b0c01d0287a16ce89b6)

[Mahara Bot (dev-mahara)]

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/10194

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10194
Committed: https://git.mahara.org/mahara/mahara/commit/bb2400187f97f49910834f48ab56d45d330a57b5
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit bb2400187f97f49910834f48ab56d45d330a57b5
Author: anupamadharmajan <email address hidden>
Date: Wed Jul 17 17:46:00 2019 +1000

Bug 1834470: Profile picture generates error when uploaded to Image Gallery.

Fixed undefined upload_max_filesize variable and artefact type mismatch for profileicon

Sponsored by The Australian National University

behatnotneeded

Change-Id: I2014806ffbf8d36311d857f43de359e3f477dc58
(cherry picked from commit 99c885321e66eb386f744b0c01d0287a16ce89b6)

[Mahara Bot (dev-mahara)]

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/10195

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10195
Committed: https://git.mahara.org/mahara/mahara/commit/f25f212c262c78cf074a3f88ef73357a89d9cbe2
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit f25f212c262c78cf074a3f88ef73357a89d9cbe2
Author: anupamadharmajan <email address hidden>
Date: Wed Jul 17 17:46:00 2019 +1000

Bug 1834470: Profile picture generates error when uploaded to Image Gallery.

Fixed undefined upload_max_filesize variable and artefact type mismatch for profileicon

Sponsored by The Australian National University

behatnotneeded

Change-Id: I2014806ffbf8d36311d857f43de359e3f477dc58
(cherry picked from commit 99c885321e66eb386f744b0c01d0287a16ce89b6)