Site Admin should be able to send messages to anyone

[Ghada El-Zoghbi]

Mahara: 19.04.0
OS: Linux
DB: Postgres 10.8
Browser: n/a

Since the beginning of Mahara, site admins have always been able to send a message to any user in the system regardless of the user's notification settings.

With the introduction of isolated institutions (in 19.04), this capability has been removed.

It should be re-implemented.

[Kristina Hoeppner (kris-hoeppner)]

Thanks for your report, Ghada.

To replicate:

1. User A doesn't allow people to send him emails.
2. Site admin goes to User A's profile.
Expected result: Site admin can still send emails.

Actual result:
   a) Site admin user can't see "Send message" button on the profile page.
   b) Site admin user can see "Send message" button on the "People" page.

This will need to be tested with both isolated institutions turned off and on (config.php setting) and then "See own groups only" setting turned on and off (Admin menu -> Config site -> Site options -> Group settings).

[Kristina Hoeppner (kris-hoeppner)]

Thanks for your report, Ghada.

To replicate:

1. User A doesn't allow people to send him emails.
2. Site admin goes to User A's profile.
Expected result: Site admin can see the "Send message" button and can send emails.
Actual result: Site admin user can't see "Send message" button on the profile page.

3. Site admin goes to the "People" page.
Expected and actual result: Site admin user can see "Send message" button next to User A and send an email.

This will need to be tested with both isolated institutions turned off and on (config.php setting) and then "See own groups only" setting turned on and off (Admin menu -> Config site -> Site options -> Group settings).

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10072

[Steven (stevens-q)]

Pre-condition: Isolated institutions is turned on (config.php setting) and then "See own groups only" setting is turned on (Admin menu -> Config site -> Site options -> Group settings).

1. User A allows people to send him emails.
2. User A is in a group in which the institution admin is not a member.
2. Institution admin goes to User A's profile and ____CAN_____ see "Send message" button on the profile page and _______CAN_______ send a message.
3. Institution admin goes to the "People" page and ____CAN______ see "Send message" button on the "People" page and ______CAN______ send a message.

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10072
Committed: https://git.mahara.org/mahara/mahara/commit/e3bd6073bb258e9eb3646c2b845cc7083d0fd7fc
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e3bd6073bb258e9eb3646c2b845cc7083d0fd7fc
Author: Ghada El-Zoghbi <email address hidden>
Date: Fri Jun 7 14:33:02 2019 +1000

Bug 1831835: Site admins can send messgaes to anyone
Added behat test script
Site admins can send to any user in the system
regardless of the user's notification settings.

This capability was mistakenly removed in 19.04.

Sponsored by The Australian National University

Change-Id: I36e83ea4ae1b7b8765d70e067f49522de0d0aeb9

[Mahara Bot (dev-mahara)]

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10073

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10073
Committed: https://git.mahara.org/mahara/mahara/commit/88833dcad6170bbf0007bb1b176bf572ef505b5f
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 88833dcad6170bbf0007bb1b176bf572ef505b5f
Author: Ghada El-Zoghbi <email address hidden>
Date: Fri Jun 7 14:33:02 2019 +1000

Bug 1831835: Site admins can send messgaes to anyone
Added behat test script
Site admins can send to any user in the system
regardless of the user's notification settings.

This capability was mistakenly removed in 19.04.

Sponsored by The Australian National University

Change-Id: I36e83ea4ae1b7b8765d70e067f49522de0d0aeb9
(cherry picked from commit e3bd6073bb258e9eb3646c2b845cc7083d0fd7fc)