Student can overwrite Teacher assessment by clicking Save annotation

[Steven]

TITLE: Student can overwrite Teacher assessment by clicking Save annotation

BUG SUMMARY: When a student has submitted a smart evidence collection and it has been assessed by Inst admin. The student can then go to the aspect that was assessed and make a feedback comment and press the save button located in the assessment area of the modal window and revert the assessment back to ready for assessment.
==============================================

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) Mahara user exists (no roles)
2) Inst admin exists
3) A collection with Smart evidence exists

TEST STEPS:
------------------------
1) Mahara user makes first annotation so that the Inst admin can assess
2) Institution admin makes an assessment of Meets standard and makes a feedback comment
3) Mahara user clicks on the assessment to view the feedback comment that the Inst admin has made
4) Mahara user then clicks the save button in the Assessment area of the modal

Expected Result: The Mahara user should never be able to change the assessment after it has been assessed. The user should not be able to interact with the save button in the Assessment area of the modal at all

Actual Result: Mahara user clicks the save button in the Assessment area of the modal to close the modal and the assessment is changed back to ready for assessment

[Steven (stevens-q)]

Ran the above Test script using 18.04 - and the same issue as above was encountered

Catalyst QA

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10188

[Steven (stevens-q)]

Commit hash: 87cceb0ccb2d52108ddc78b0bc0a3b67da3acd8b
Environment tested: Master
Browser tested: Chrome
Theme used: Raw

PRECONDITIONS:
------------------------
1) Mahara user exists (no roles)
2) Inst admin exists
3) A collection with Smart evidence exists

TEST STEPS:
------------------------
1) Mahara user makes first annotation so that the Inst admin can assess
2) Institution admin makes an assessment of Meets standard and makes a feedback comment
3) Mahara user clicks on the assessment to view the feedback comment that the Inst admin has made
4) Mahara user then clicks the save button in the Assessment area of the modal
5) Verify The Mahara user should never be able to change the assessment after it has been assessed. ✔

Catalyst QA Approved ✔

[Mahara Bot (dev-mahara)]

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/10201

[Steven (stevens-q)]

BUG SUMMARY:
1) When a self assessment has been made by student owner of collection and Inst admin has access to collection The Inst admin can then go to the aspect that was assessed and make a feedback comment and press the save button located in the assessment area of the modal window and revert the assessment back to ready for assessment.

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) Mahara user exists (no roles)
2) Inst admin exists
3) A collection with Self assessment framework exists
4) Collection shared with Institution

TEST STEPS:
------------------------
1) Mahara user makes first annotation and then proceeds to make a self assessment
2) Institution admin clicks on the assessment to view
4) Institution admin then clicks the save button in the Assessment area of the modal

Expected result:
Save and cancel buttons should not be displayed for Inst admin for a self assessment collection who has access to collection and after a self assessment has been made

Actual result: Save and cancel buttons are displayed and Inst admin can click the save button in the Assessment area of the modal to close the modal and the assessment is changed back to ready for assessment

[Steven (stevens-q)]

Commit hash: 2ae2f0cec598acee5087eabc08a117e509c8ef65
Environment tested: Master
Browser tested: Chrome
Theme used: Raw

PRECONDITIONS:
------------------------
1) Mahara user exists (no roles)
2) Inst admin exists
3) A collection with Smart evidence exists

TEST STEPS: Verify the SmartEvidence assessment is working
------------------------
1) Mahara user makes first annotation so that the Inst admin can assess
2) Institution admin makes an assessment of Meets standard and makes a feedback comment
3) Mahara user clicks on the assessment to view the feedback comment that the Inst admin has made
4) Mahara user then clicks the save button in the Assessment area of the modal
5) Verify The Mahara user should never be able to change the assessment after it has been assessed. ✔

Catalyst QA Approved ✔

*************************************************************************************

Commit hash: 2ae2f0cec598acee5087eabc08a117e509c8ef65
Environment tested: Master
Browser tested: Chrome
Theme used: Raw

PRECONDITIONS:
------------------------
1) Mahara user exists (no roles)(Earl User5)
2) Inst admin exists (Bob User2 = admin instone)
3) A collection exists with the following
a) Smart evidence self assess framework (Self assessment = True & framework = active)
b) Inst admin has been given access to the self assessment collection

TEST STEPS: Verify the self assessment is working
------------------------
1) Log in as Inst admin
2) View the Collection with the self assessment
3) Verify the Institution admin should never be able to change the self assessment after it has been assessed by the Student /owner of collection. ✔

Catalyst QA Approved ✔

[Steven (stevens-q)]

Commit hash: 2ae2f0cec598acee5087eabc08a117e509c8ef65
Environment tested: 18.04_STABLE
Browser tested: Chrome
Theme used: Raw

PRECONDITIONS:
------------------------
1) Mahara user exists (no roles)(Earl User5)
2) Inst admin exists (Bob User2 = admin instone)
3) A collection exists with the following
a) Smart evidence self assess framework (Self assessment = True & framework = active) (easiest way to do this is through the DB frameworks table)
b) Inst admin has been given access to the self assessment collection

TEST STEPS: Verify the self assessment is working
------------------------
1) Log in as Inst admin
2) View the Collection with the self assessment
3) Verify the Institution admin should never be able to change the self assessment after it has been assessed by the Student /owner of collection. ✔

Catalyst QA Approved ✔

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10201
Committed: https://git.mahara.org/mahara/mahara/commit/911ecf2e80f56db716219e820b8e89792e660fbe
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit 911ecf2e80f56db716219e820b8e89792e660fbe
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Jul 19 10:56:24 2019 +1200

Bug 1825282: Show only html in smartevidence add feedback modal

for the owner of the collection when the framework is not a
self-assess one

behatnotneeded

Change-Id: Iac63c94b7e07a526e2e8790de1d7f4fc7e409160

[Mahara Bot (dev-mahara)]

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10215

[Mahara Bot (dev-mahara)]

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/10216

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10215
Committed: https://git.mahara.org/mahara/mahara/commit/ef6b8032fffda59253b6a6056f39a8239a9cb946
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.04_STABLE

commit ef6b8032fffda59253b6a6056f39a8239a9cb946
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Jul 19 10:56:24 2019 +1200

Bug 1825282: Show only html in smartevidence add feedback modal

for the owner of the collection when the framework is not a
self-assess one
and for institution staff when the framework is a self-assess one

behatnotneeded

Change-Id: Iac63c94b7e07a526e2e8790de1d7f4fc7e409160

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10216
Committed: https://git.mahara.org/mahara/mahara/commit/151207ade7bc7d4cc9ff3a089aad738fed90c888
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.10_STABLE

commit 151207ade7bc7d4cc9ff3a089aad738fed90c888
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Jul 19 10:56:24 2019 +1200

Bug 1825282: Show only html in smartevidence add feedback modal

for the owner of the collection when the framework is not a
self-assess one
and for institution staff when the framework is a self-assess one

behatnotneeded

Change-Id: Iac63c94b7e07a526e2e8790de1d7f4fc7e409160

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10188
Committed: https://git.mahara.org/mahara/mahara/commit/2ae2f0cec598acee5087eabc08a117e509c8ef65
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 2ae2f0cec598acee5087eabc08a117e509c8ef65
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Jul 19 10:56:24 2019 +1200

Bug 1825282: Show only html in smartevidence add feedback modal

for the owner of the collection when the framework is not a
self-assess one
and for institution staff when the framework is a self-assess one

behatnotneeded

Change-Id: Iac63c94b7e07a526e2e8790de1d7f4fc7e409160