Getting PHP Fatal error: Cannot redeclare serve_file() when using sync_langpacks

Bug #1895901 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Unassigned
19.04
High
Unassigned
19.10
High
Unassigned
20.04
High
Unassigned
20.10
High
Unassigned

Bug Description

This is because we are using require() instead of require_once() in sync_langpacks.php

Robert Lyon (robertl-9)
Changed in mahara:
importance: Undecided → High
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11278
Committed: https://git.mahara.org/mahara/mahara/commit/5b0a7106f793b2adef665773945013d5eeda04f8
Submitter: Lisa Seeto (<email address hidden>)
Branch: master

commit 5b0a7106f793b2adef665773945013d5eeda04f8
Author: Robert Lyon <email address hidden>
Date: Thu Sep 17 10:57:50 2020 +1200

Bug 1895901: Make sure we only call included files once

Otherwise we can end up with
PHP Fatal error: Cannot redeclare serve_file() (previously declared
in htdocs/lib/file.php:38) in htdocs/lib/file.php on line 171

Change-Id: I020393a395543738c9054783698e2665160308f8
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/11282

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11283

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11284

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11284
Committed: https://git.mahara.org/mahara/mahara/commit/0133cd96bd73047d0b8ccc04920530af8070a3c6
Submitter: Lisa Seeto (<email address hidden>)
Branch: 20.04_STABLE

commit 0133cd96bd73047d0b8ccc04920530af8070a3c6
Author: Robert Lyon <email address hidden>
Date: Thu Sep 17 10:57:50 2020 +1200

Bug 1895901: Make sure we only call included files once

Otherwise we can end up with
PHP Fatal error: Cannot redeclare serve_file() (previously declared
in htdocs/lib/file.php:38) in htdocs/lib/file.php on line 171

Change-Id: I020393a395543738c9054783698e2665160308f8
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 5b0a7106f793b2adef665773945013d5eeda04f8)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11283
Committed: https://git.mahara.org/mahara/mahara/commit/6c9de8b6f7502cc5fff36bb5504ba2573a864a1f
Submitter: Lisa Seeto (<email address hidden>)
Branch: 19.10_STABLE

commit 6c9de8b6f7502cc5fff36bb5504ba2573a864a1f
Author: Robert Lyon <email address hidden>
Date: Thu Sep 17 10:57:50 2020 +1200

Bug 1895901: Make sure we only call included files once

Otherwise we can end up with
PHP Fatal error: Cannot redeclare serve_file() (previously declared
in htdocs/lib/file.php:38) in htdocs/lib/file.php on line 171

Change-Id: I020393a395543738c9054783698e2665160308f8
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 5b0a7106f793b2adef665773945013d5eeda04f8)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11282
Committed: https://git.mahara.org/mahara/mahara/commit/3181f4b887b1363b147cfeae2e6bf159e7a22864
Submitter: Lisa Seeto (<email address hidden>)
Branch: 19.04_STABLE

commit 3181f4b887b1363b147cfeae2e6bf159e7a22864
Author: Robert Lyon <email address hidden>
Date: Thu Sep 17 10:57:50 2020 +1200

Bug 1895901: Make sure we only call included files once

Otherwise we can end up with
PHP Fatal error: Cannot redeclare serve_file() (previously declared
in htdocs/lib/file.php:38) in htdocs/lib/file.php on line 171

Change-Id: I020393a395543738c9054783698e2665160308f8
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 5b0a7106f793b2adef665773945013d5eeda04f8)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.10.0 → none
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers