Google Apps Block unable to parse URL to google drive folder

Bug #1892790 reported by Lisa Seeto
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Lisa Seeto
19.04
High
Unassigned
19.10
High
Unassigned
20.04
High
Unassigned
20.10
High
Lisa Seeto

Bug Description

Google Drive URLs aren't parsed correctly any more and don't display the Google Drive folder icon (or whatever needs to be displayed).

For example, the folder https://drive.google.com/drive/folders/0B-V_s ... 00Y2JmLTkwNjUtZGM0ODJiZGNjYWEy has been shared publicly but on MyPortfolio (and also master) it only displays:

"Unable to parse embedded code or URL: https://drive.google.com/drive/folders/0B-V_s ... 0Y2JmLTkwNjUtZGM0ODJiZGNjYWEy"

To replicate:
1. Log in and create a page and select to create a "Google Apps" block
2. In the "Embed code or URL" put the above url and save the block.
Expected results:
The block displays with icon etc... correctly
Actual results:
The block displays with "Unable to parse embedded code or URL: https://drive.google.com/drive/folders/0B-V_s9Ys157uZmFkY2RlOWMtNGY4Yy00Y2JmLTkwNjUtZGM0ODJiZGNjYWEy "

Our regex is failing to parse this pattern and we'll need to add to it while keeping any necessary previous patterns for backwards compatibility.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11177

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11177
Committed: https://git.mahara.org/mahara/mahara/commit/2c46d657df3487de3636992b716e7b5a36e477c5
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 2c46d657df3487de3636992b716e7b5a36e477c5
Author: Lisa Seeto <email address hidden>
Date: Tue Aug 25 10:59:25 2020 +1200

Bug 1892790: Google Apps Block unable to parse URL to google drive folder

- added new pattern to match drive.google.com/folders

Change-Id: I0df15ec721eb88fadc1d9ae7ffa5cdef6313171b
Signed-off-by: Lisa Seeto <email address hidden>

Changed in mahara:
importance: Undecided → High
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/11212

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11213

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11214

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11212
Committed: https://git.mahara.org/mahara/mahara/commit/c9dd0a9fefe2dcd7b2b2883c0e26454d5ef40685
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit c9dd0a9fefe2dcd7b2b2883c0e26454d5ef40685
Author: Lisa Seeto <email address hidden>
Date: Tue Aug 25 10:59:25 2020 +1200

Bug 1892790: Google Apps Block unable to parse URL to google drive folder

- added new pattern to match drive.google.com/folders

Change-Id: I0df15ec721eb88fadc1d9ae7ffa5cdef6313171b
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit 2c46d657df3487de3636992b716e7b5a36e477c5)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11213
Committed: https://git.mahara.org/mahara/mahara/commit/8ed14ee0e0f85bee284d5e6f6501a2877b7e6c65
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit 8ed14ee0e0f85bee284d5e6f6501a2877b7e6c65
Author: Lisa Seeto <email address hidden>
Date: Tue Aug 25 10:59:25 2020 +1200

Bug 1892790: Google Apps Block unable to parse URL to google drive folder

- added new pattern to match drive.google.com/folders

Change-Id: I0df15ec721eb88fadc1d9ae7ffa5cdef6313171b
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit 2c46d657df3487de3636992b716e7b5a36e477c5)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11214
Committed: https://git.mahara.org/mahara/mahara/commit/54b9752007c2222474bbb5b64c40e5afb9460112
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit 54b9752007c2222474bbb5b64c40e5afb9460112
Author: Lisa Seeto <email address hidden>
Date: Tue Aug 25 10:59:25 2020 +1200

Bug 1892790: Google Apps Block unable to parse URL to google drive folder

- added new pattern to match drive.google.com/folders

Change-Id: I0df15ec721eb88fadc1d9ae7ffa5cdef6313171b
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit 2c46d657df3487de3636992b716e7b5a36e477c5)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.10.0 → none
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers