Block header buttons need better labels when Editing Pages

Bug #1887450 reported by Lisa Seeto
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
High
Lisa Seeto
19.04
High
Unassigned
19.10
High
Unassigned
20.04
High
Unassigned
20.10
High
Lisa Seeto

Bug Description

It was found that the labels for the buttons that appear when editing a block on a page are not accurately described by a screen reader. The buttons are "Configure block" and "Remove block". The "Remove block" button was entirely missing its label for screen readers, while the "Configure block" reads "Move block" instead of configure block.

It looks like the 'sr-only' class needs to be applied correctly to the configure block button so that it misses the move button text and addresses its own purposes and for it to be applied to the remove block button in blocktypecontainerediting.tpl

Changed in mahara:
status: New → Triaged
Lisa Seeto (lisaseeto)
Changed in mahara:
assignee: nobody → Lisa Seeto (lisaseeto)
status: Triaged → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11201

Changed in mahara:
importance: Undecided → High
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11201
Committed: https://git.mahara.org/mahara/mahara/commit/dfba48441f62785a23fa2603c3c6e85b16af0fac
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit dfba48441f62785a23fa2603c3c6e85b16af0fac
Author: Lisa Seeto <email address hidden>
Date: Tue Sep 1 15:05:24 2020 +1200

Bug 1887450: Block header buttons need better labels when Editing Pages

- add in sr-only tags for buttons

Change-Id: I47ca334ea8c197a782641d23843ee8959d5e4e05
Signed-off-by: Lisa Seeto <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11243

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11243
Committed: https://git.mahara.org/mahara/mahara/commit/f46ad3d9af4f51fc7975d44cf23d05d5cb0fcefa
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 20.04_STABLE

commit f46ad3d9af4f51fc7975d44cf23d05d5cb0fcefa
Author: Lisa Seeto <email address hidden>
Date: Tue Sep 1 15:05:24 2020 +1200

Bug 1887450: Block header buttons need better labels when Editing Pages

- add in sr-only tags for buttons

Change-Id: I47ca334ea8c197a782641d23843ee8959d5e4e05
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit dfba48441f62785a23fa2603c3c6e85b16af0fac)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11244

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11244
Committed: https://git.mahara.org/mahara/mahara/commit/eebb1e1dbeee886478fbe01067a48874dc0e5067
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit eebb1e1dbeee886478fbe01067a48874dc0e5067
Author: Lisa Seeto <email address hidden>
Date: Tue Sep 1 15:05:24 2020 +1200

Bug 1887450: Block header buttons need better labels when Editing Pages

- add in sr-only tags for buttons

Change-Id: I47ca334ea8c197a782641d23843ee8959d5e4e05
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit dfba48441f62785a23fa2603c3c6e85b16af0fac)
(cherry picked from commit f46ad3d9af4f51fc7975d44cf23d05d5cb0fcefa)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/11245

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11245
Committed: https://git.mahara.org/mahara/mahara/commit/4b27a8fa06df7bfd104c91fc6916b48d9fc3d3f3
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.04_STABLE

commit 4b27a8fa06df7bfd104c91fc6916b48d9fc3d3f3
Author: Lisa Seeto <email address hidden>
Date: Tue Sep 1 15:05:24 2020 +1200

Bug 1887450: Block header buttons need better labels when Editing Pages

- add in sr-only tags for buttons

Change-Id: I47ca334ea8c197a782641d23843ee8959d5e4e05
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit dfba48441f62785a23fa2603c3c6e85b16af0fac)
(cherry picked from commit f46ad3d9af4f51fc7975d44cf23d05d5cb0fcefa)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.10.0 → none
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Related blueprints