usr.active not changed when unexpiring a user from admin/user/edit.php screen

Bug #1886593 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Cecilia Vela Gurovic
19.04
Fix Released
High
Unassigned
19.10
Fix Released
High
Unassigned
20.04
Fix Released
High
Unassigned
20.10
Fix Released
High
Cecilia Vela Gurovic

Bug Description

When we expire a user their 'active' field in database usr table goes from 1 to 0 and if we un-expire them from the expired users list it sets it back to active correctly

But if we try updating the user from admin/users/edit.php screen by adding / removing the expiry date in the form field it doesn't set the active value correctly

Robert Lyon (robertl-9)
Changed in mahara:
assignee: nobody → Robert Lyon (robertl-9)
milestone: none → 20.10.0
status: New → Confirmed
Changed in mahara:
importance: Undecided → High
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/11137

Changed in mahara:
assignee: Robert Lyon (robertl-9) → Cecilia Vela Gurovic (ceciliavg)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11137
Committed: https://git.mahara.org/mahara/mahara/commit/c6f178f0b64adc274b89c782d8d9d7c8551ec671
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c6f178f0b64adc274b89c782d8d9d7c8551ec671
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Aug 13 17:12:18 2020 +1200

Bug 1886593: activate user when un-expiring the account

behatnotneeded

Change-Id: I6fa5ae752fab547446b6dfbd148e1b8d72dd41e9

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11168

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11169

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/11170

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/11169
Committed: https://git.mahara.org/mahara/mahara/commit/ffa5657d5018a636d828f8851c98b077fa1d538d
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit ffa5657d5018a636d828f8851c98b077fa1d538d
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Aug 13 17:12:18 2020 +1200

Bug 1886593: activate user when un-expiring the account

behatnotneeded

Change-Id: I6fa5ae752fab547446b6dfbd148e1b8d72dd41e9
(cherry picked from commit c6f178f0b64adc274b89c782d8d9d7c8551ec671)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11170
Committed: https://git.mahara.org/mahara/mahara/commit/be6d17e1d2c0a711652bccbf6f712bcf6fac608e
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit be6d17e1d2c0a711652bccbf6f712bcf6fac608e
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Aug 13 17:12:18 2020 +1200

Bug 1886593: activate user when un-expiring the account

behatnotneeded

Change-Id: I6fa5ae752fab547446b6dfbd148e1b8d72dd41e9
(cherry picked from commit c6f178f0b64adc274b89c782d8d9d7c8551ec671)

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/11168
Committed: https://git.mahara.org/mahara/mahara/commit/c07987a34f864fd1b77cf93a868f7b56111b8bdf
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit c07987a34f864fd1b77cf93a868f7b56111b8bdf
Author: Cecilia Vela Gurovic <email address hidden>
Date: Thu Aug 13 17:12:18 2020 +1200

Bug 1886593: activate user when un-expiring the account

behatnotneeded

Change-Id: I6fa5ae752fab547446b6dfbd148e1b8d72dd41e9
(cherry picked from commit c6f178f0b64adc274b89c782d8d9d7c8551ec671)

Robert Lyon (robertl-9)
Changed in mahara:
milestone: 20.10.0 → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.