Bug #1885982 “behat headless doesn't work with chrome 80” : Series 19.04 : Bugs : Mahara

Cecilia Vela Gurovic (ceciliavg) on 2020-07-13

Changed in mahara:
milestone:	none → 20.10.0

Cecilia Vela Gurovic (ceciliavg) on 2020-07-13

Changed in mahara:
importance:	Undecided → Medium
status:	New → In Progress
assignee:	nobody → Cecilia Vela Gurovic (ceciliavg)

Revision history for this message

Rangi Daymond (rangid) wrote on 2020-07-20:

#1

Gerrit: https://reviews.mahara.org/#/c/10785/ Patch set 13
Browser: n/a
Theme: n/a

Precondition 1: Behat test runs successfully when NOT executed headless.
a) On master, before patch applied.
b) Use the following feature file & command to execute it:
   ./test/behat/mahara_behat.sh rundebug copy_note_content.feature
   Actual results: User interface displayed as tests executed,
   1 scenario (1 passed), 22 steps (22 passed), 0m15.72s (35.15Mb).

Test scenario 1: Verify that Behat tests continue to run successfully after the patch is applied.
Steps:
1.1 Apply patch.
1.2 Re-execute precondition 1b)
   Expected result: the result’s scenario & steps are the same,
   the time and space results are similar.
   Actual result: ✔ as expected.
   1 scenario (1 passed), 22 steps (22 passed), 0m15.29s (35.27Mb).

Test scenario 2: Verify that headless Behat tests can run successfully
when the virtual display server is NOT running.
Steps:
2.1 Check that the virtual display server is NOT running using the terminal
command:
    ps aux |grep Xvfb
    Expected result: should only return a one line response with the following
        at then end if the virtual display server is NOT running
             .....”grep --color=auto Xvfb”.
    Actual result: ✔ as expected.
    Note: if it is necessary to stop it, use the terminal command:
    sudo kill <virtual display server processid>
2.2 Execute the Behat test headless by running the following command:
    ./test/behat/mahara_behat.sh rundebugheadless copy_note_content.feature
    Expected result: as per precondition actual results.
    Actual result: ✔ as expected,
    i.e. 1 scenario (1 passed), 22 steps (22 passed), 0m15.07s (35.27Mb)
    – refer to the attached text file for the full results.

Test scenario 3: Verify that headless Behat tests can run successfully
when the display server IS running.
Precondition 2: Test scenario 2 has been executed successfully.
Steps:
3.1 Ensure that the virtual display server is running on port 10,
    using the terminal command:
    ps aux |grep Xvfb
    Expected result: should return a two line response, one line will have
        the following at then end if the virtual display server IS running
             .....”Xvfb :10 -ac”
    Note: to execute it if it is NOT running, use the terminal command:
    Xvfb :10 -ac
    Actual result: ✔ as expected – refer attached terminal text file
3.2 Execute the Behat test headless:
    ./test/behat/mahara_behat.sh rundebugheadless copy_note_content.feature
    Expected result: as per precondition 1 actual results, and,
       a port other than 10 is used.
    Actual result: ✔ as expected, port 11 used
    i.e. 1 scenario (1 passed), 22 steps (22 passed), 0m14.88s (35.27Mb)
    – refer to the attached text file for the full results.

Gerrit: https://reviews.mahara.org/#/c/10785/ Patch set 13
Browser: n/a
Theme: n/a

Precondition 1: Behat test runs successfully when NOT executed headless.
a) On master, before patch applied.
b) Use the following  feature file & command to execute it:
   ./test/behat/mahara_behat.sh rundebug copy_note_content.feature
   Actual results: User interface displayed as tests executed,
   1 scenario (1 passed), 22 steps (22 passed), 0m15.72s (35.15Mb).

Test scenario 1: Verify that Behat tests continue to run successfully after the patch is applied.
Steps:
1.1 Apply patch.
1.2 Re-execute precondition 1b)
   Expected result: the result’s scenario & steps are the same,
   the time and space results are similar.
   Actual result: ✔ as expected.
   1 scenario (1 passed), 22 steps (22 passed), 0m15.29s (35.27Mb).

Test scenario 2: Verify that headless Behat tests can run successfully
when the virtual display server is NOT running.
Steps:
2.1 Check that the virtual display server is NOT running using the terminal
command:
    ps aux |grep Xvfb
    Expected result: should only return a one line response with the following
        at then end if the virtual display server is NOT running
             .....”grep --color=auto Xvfb”.
    Actual result: ✔ as expected.
    Note: if it is necessary to stop it, use the terminal command:
    sudo kill <virtual display server processid>
2.2 Execute the Behat test headless by running the following command:
    ./test/behat/mahara_behat.sh rundebugheadless copy_note_content.feature
    Expected result: as per precondition actual results.
    Actual result: ✔ as expected,
    i.e. 1 scenario (1 passed), 22 steps (22 passed), 0m15.07s (35.27Mb)
    – refer to the attached text file for the full results.

Test scenario 3: Verify that headless Behat tests can run successfully
when the display server IS running.
Precondition 2: Test scenario 2 has been executed successfully.
Steps:
3.1 Ensure that the virtual display server is running on port 10, 
    using the terminal command:
    ps aux |grep Xvfb
    Expected result: should return a two line response, one line will have
        the following at then end if the virtual display server IS running
             .....”Xvfb :10 -ac”
    Note: to execute it if it is NOT running, use the terminal command:
    Xvfb :10 -ac
    Actual result: ✔ as expected – refer attached terminal text file
3.2 Execute the Behat test headless:
    ./test/behat/mahara_behat.sh rundebugheadless copy_note_content.feature
    Expected result: as per precondition 1 actual results, and,
       a port other than 10 is used.
    Actual result: ✔ as expected, port 11 used
    i.e. 1 scenario (1 passed), 22 steps (22 passed), 0m14.88s (35.27Mb)
    – refer to the attached text file for the full results.

Revision history for this message

Rangi Daymond (rangid) wrote on 2020-07-20:

#2

Bug1885982TerminalActualResults.odt Edit (21.1 KiB, application/vnd.oasis.opendocument.text)

Highlighted actual results from terminal file attached

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-07-21: A change has been merged

#3

Reviewed: https://reviews.mahara.org/10785
Committed: https://git.mahara.org/mahara/mahara/commit/c4dbe35d38bf339f52a172c9a31969badd21649b
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c4dbe35d38bf339f52a172c9a31969badd21649b
Author: Robert Lyon <email address hidden>
Date: Wed Mar 4 09:03:41 2020 +1300

Bug 1885982: add -screen pixel depth and related xvfb params for bionic and chrome 80

fixes issue with chrome 80 and xvfb where default parameters (prob pixel depth)
makes chrome fail to connect to xvfb/selenium.

Change-Id: Ib02ddf98318410cbc5257fa33829c89341e5fc1e

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-08-10: A patch has been submitted for review

#4

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/11118

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-08-10:

#6

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/11119

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-08-10:

#7

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/11120

Revision history for this message

Robert Lyon (robertl-9) wrote on 2020-08-10:

#5

Need to backport to allow behat testing to work as expected on older branches

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-08-12: A change has been merged

#8

Reviewed: https://reviews.mahara.org/11120
Committed: https://git.mahara.org/mahara/mahara/commit/0a314602e3b318d103909c28fc35b72f05fe3cc8
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 0a314602e3b318d103909c28fc35b72f05fe3cc8
Author: Robert Lyon <email address hidden>
Date: Wed Mar 4 09:03:41 2020 +1300

Bug 1885982: add -screen pixel depth and related xvfb params for bionic and chrome 80

fixes issue with chrome 80 and xvfb where default parameters (prob pixel depth)
makes chrome fail to connect to xvfb/selenium.

Change-Id: Ib02ddf98318410cbc5257fa33829c89341e5fc1e
(cherry picked from commit c4dbe35d38bf339f52a172c9a31969badd21649b)

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-08-14:

#9

Reviewed: https://reviews.mahara.org/11119
Committed: https://git.mahara.org/mahara/mahara/commit/e613d46ceee683a7866589ad422104df1f348484
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.10_STABLE

commit e613d46ceee683a7866589ad422104df1f348484
Author: Robert Lyon <email address hidden>
Date: Wed Mar 4 09:03:41 2020 +1300

Bug 1885982: add -screen pixel depth and related xvfb params for bionic and chrome 80

fixes issue with chrome 80 and xvfb where default parameters (prob pixel depth)
makes chrome fail to connect to xvfb/selenium.

Change-Id: Ib02ddf98318410cbc5257fa33829c89341e5fc1e
(cherry picked from commit c4dbe35d38bf339f52a172c9a31969badd21649b)

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2020-08-14:

#10

Reviewed: https://reviews.mahara.org/11118
Committed: https://git.mahara.org/mahara/mahara/commit/e918691a869733730ba94803333a7f110d45e067
Submitter: Robert Lyon (<email address hidden>)
Branch: 20.04_STABLE

commit e918691a869733730ba94803333a7f110d45e067
Author: Robert Lyon <email address hidden>
Date: Wed Mar 4 09:03:41 2020 +1300

Bug 1885982: add -screen pixel depth and related xvfb params for bionic and chrome 80

fixes issue with chrome 80 and xvfb where default parameters (prob pixel depth)
makes chrome fail to connect to xvfb/selenium.

Change-Id: Ib02ddf98318410cbc5257fa33829c89341e5fc1e
(cherry picked from commit c4dbe35d38bf339f52a172c9a31969badd21649b)

Robert Lyon (robertl-9) on 2020-11-01

Changed in mahara:
milestone:	20.10.0 → none

Kristina Hoeppner (kris-hoeppner) on 2020-11-08

no longer affects:

mahara

	Status	Importance	Assigned to	Milestone
Mahara
19.04	Fix Released	Medium	Unassigned	Mahara 19.04.7
19.10	Fix Released	Medium	Unassigned	Mahara 19.10.5
20.04	Fix Released	Medium	Unassigned	Mahara 20.04.2
20.10	Fix Released	Medium	Cecilia Vela Gurovic	Mahara 20.10.0

Mahara

behat headless doesn't work with chrome 80

Bug Description

Other bug subscribers

Bug attachments

Remote bug watches