'My groups' sidebar can get very long if you are in lots of groups

[Robert Lyon]

When you are a member of many groups the list in the sidebar can get very long

There is an account preference to restrict the list to 'Maximum number of groups to display'

And now there is an account preference to restrict it to certain group labels

But both these options require user making choices / setting up labels

Another option to make the 'My groups' side bar a little more manageable is via css

This option still lets you scroll to see all your groups but doesn't make the page overly long.

Note: (25 May - after Robert questioned about how many groups should display before the scroll bar is displayed): apparently the 'My groups' sidebar should be 400px high maximum (or a scroll bar will be displayed). When browser View set at 100% this equates to approximately 14 lines(Chrome, Firefox & Edge), this number will vary depending upon the browser View setting +100-. The number of groups shown before scrolling is also variable due to how many groups the person is admin for (2 lines) versus not admin for (1 line). The length of the group name will also impact how many lines are taken per group.

[Robert Lyon (robertl-9)]

To test:

Use the provided csv files

Upload them via the
- Admin -> Groups -> Add groups
- Admin -> Groups -> Add group members

You should end up with your admin user being in 40 groups and a long 'My groups' sidebar on Dashboard page

With patch - the sidebar should be way smaller and have a scrollbar in it

When setting account setting 'Maximum number of groups to display' to 5 then the sidebar should not have scrollbar

[Rangi Daymond (rangid)]

Gerrit: https://reviews.mahara.org/#/c/9521/ Patch set 3
 Bug 1875958: Allow groups list sideblock to have max height / scroll

All test cases PASSED - please refer to the attached execution spreadsheet for expected and actual results.

Test Scenario 1: Groups list sidebar scroll successfully implemented for new database.
--------------------------------------------------------------------------------------
Environment: Windows10 and latest Edge & Chrome browsers.
Theme: vary person's theme through testing to use all 5 (Primary school, Default, Modern, Ocean and Raw).
 - change at 'Account menu' > 'Settings' > 'Preferences' --> select 'Theme' (provided you have the config.php setting '$cfg->sitethemeprefs = true;' set.

Preconditions:
With patch applied and a clean database:
a) Create accounts: 'Admin menu' > 'People' > 'Add people by csv'
 *** Force password change --> No
 *** Email people about their account --> No
 select file '20 user_users_1-20 mine.csv' (in directory Mahara/SeUp_Intro).

b) Populate the group categories: 'Admin menu' > 'Groups' > 'Group categories'
 Enable group categories --> Yes then 'Submit'
 Enter then 'Add' each of the following values in 'Enter new group category':
  Category 1
  Category 2
  Category 3
  Category 4
  A really long category name well it wasn’t but it is much longer now being a total of 222 characters now – & it also includes punctuation and a mācron and other special characters too! And is now pushed out to > 200 of em.

c) Create the groups: 'Admin menu' > 'Groups' > 'Add groups by CSV'
 select file 'My30_groups.csv' (in directory Mahara/SeUp_Intro).

d) Populate some groups with members: 'Admin menu' > 'Groups' > 'Update group members by CSV'
 select file 'My30_group_members.csv' (in directory Mahara/SeUp_Intro).

e) Ensure that the target browser's viewport View is set to 100%.

Steps:
1.1 Log in with the targeted person and verify that the scroll bar:
    1.1.1 appears and functions correctly when the person's groups list is 400 or more pixels high.
    1.1.2 does not appear when the person's groups list is less than 400px400 high.
    1.1.3 is added and functions correctly when the list is extended from less than 400px to more than 400px.
    1.1.4 is removed when the list is reduced to less than 400px after being more than 400px.

1.2 Verify that the scroll bar appears and functions correctly when a display maximum is set in the 'Account menu' > 'Settings' > 'Preferences' --> 'Maximum number of groups to display':
    1.2.1 appears and functions correctly when the set maximum groups list is 400 or more pixels high.
    1.2.2 does not appear when the set maximum groups list is less than 400 high.

1.3 Verify that the scroll bar appears and functions correctly when a group label display filter is set in the 'Account menu' > 'Settings' > 'Preferences' --> 'Display only groups labelled with':
    1.3.1 appears and functions correctly when the filtered groups list is 400 or more pixels high.
    1.3.2 does not appear when the filtered groups list is less than 400px400 high.

1.4 Verify that the scroll bar appears and functions correctly when both:
   - a display maximum is set in the 'Account...

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/9521
Committed: https://git.mahara.org/mahara/mahara/commit/c7178676052624b293aa4e641d7176abd02ae656
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit c7178676052624b293aa4e641d7176abd02ae656
Author: Robert Lyon <email address hidden>
Date: Tue Feb 5 09:31:56 2019 +1300

Bug 1875958: Allow groups list sideblock to have max height / scroll

Change-Id: I9e73feb22519c1e62392ef19182500ba16f96229
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "20.04_STABLE" branch: https://reviews.mahara.org/10997

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10997
Committed: https://git.mahara.org/mahara/mahara/commit/59f6755263ac159902f3eb53ebfd7aa276a69f13
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 20.04_STABLE

commit 59f6755263ac159902f3eb53ebfd7aa276a69f13
Author: Robert Lyon <email address hidden>
Date: Tue Feb 5 09:31:56 2019 +1300

Bug 1875958: Allow groups list sideblock to have max height / scroll

Change-Id: I9e73feb22519c1e62392ef19182500ba16f96229
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c7178676052624b293aa4e641d7176abd02ae656)

[Mahara Bot (dev-mahara)]

Patch for "19.10_STABLE" branch: https://reviews.mahara.org/10998

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10998
Committed: https://git.mahara.org/mahara/mahara/commit/b6ad599b00e77f70980a6390afedc7b0ae69c518
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.10_STABLE

commit b6ad599b00e77f70980a6390afedc7b0ae69c518
Author: Robert Lyon <email address hidden>
Date: Tue Feb 5 09:31:56 2019 +1300

Bug 1875958: Allow groups list sideblock to have max height / scroll

Change-Id: I9e73feb22519c1e62392ef19182500ba16f96229
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c7178676052624b293aa4e641d7176abd02ae656)
(cherry picked from commit 59f6755263ac159902f3eb53ebfd7aa276a69f13)

[Mahara Bot (dev-mahara)]

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10999

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10999
Committed: https://git.mahara.org/mahara/mahara/commit/dd6129978ccb1ec51a28ba4dc18064384adb4834
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 19.04_STABLE

commit dd6129978ccb1ec51a28ba4dc18064384adb4834
Author: Robert Lyon <email address hidden>
Date: Tue Feb 5 09:31:56 2019 +1300

Bug 1875958: Allow groups list sideblock to have max height / scroll

Change-Id: I9e73feb22519c1e62392ef19182500ba16f96229
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit c7178676052624b293aa4e641d7176abd02ae656)
(cherry picked from commit 59f6755263ac159902f3eb53ebfd7aa276a69f13)
(cherry picked from commit b6ad599b00e77f70980a6390afedc7b0ae69c518)

[Rangi Daymond (rangid)]

Upload:
1. Test execution spreadsheet, and,
2. Zipped test files (TestFiles.zip)
     - includes 3; 20users.csv, groups_My34.csv and group_members_My34.csv.

[Rangi Daymond (rangid)]

See previous comment regarding TestFiles.zip content.