Bulk import doesn't retain user details correctly

[Kristina Hoeppner]

This was reported at https://mahara.org/interaction/forum/topic.php?id=8502

I can confirm it with a bulk export from account on demo.mahara.org (attached).

For details, see the forum post.

To replicate:

Have 2 or more accounts that have files and portfolio pages, e.g. from demo.mahara.org

1. Use the bulk export to export the accounts.
2. On another Mahara site, use the bulk import to import the acocunts.
Expected result: The accounts are transferred and set up as they were on the original site.

Actual result: Everybody has the same name and profile pictures are not displayed even when the accounts had some. While email addresses were shown in the site admin area Admin menu -> People -> User search, no primary email address was shown on the accounts settings page and when logging in, an email validation was to be sent.

Still to be tested on 18.10 and 18.04 if it's an issue there as well.

[Kristina Hoeppner (kris-hoeppner)]

For testing on Ubuntu, it's best to put the exported Leap2A file into "Downloads" and then find the path from there.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/10337

[Steven (stevens-q)]

Commit hash: b8f0d8fb7a9b0ced1f1453b94ec6a0578edb7719
Environment tested: Master
Browser tested: Chrome
Theme used: Raw

PRECONDITIONS:
------------------------
1) Have 2 or more accounts that have files and portfolio pages, e.g. from demo.mahara.org (see file attached in comment 1 - mahara-bulk-leap2.zip )

TEST STEPS:
------------------------
1) On demo.mahara.org use the bulk export to export the accounts. /admin/users/bulkexport.php and export the accounts of 3 users
2) On testing Mahara site with patch, use the bulk import to import the acocunts. /admin/users/bulkimport.php of the 3 users
3) Verify the accounts are transferred and set up as they were on the original site.

Catalyst QA Approved ✔

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10337
Committed: https://git.mahara.org/mahara/mahara/commit/9dc7cbc6a3a6ecdaf132888c6d755a5af20496b7
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9dc7cbc6a3a6ecdaf132888c6d755a5af20496b7
Author: Lisa Seeto <email address hidden>
Date: Thu Sep 12 12:08:59 2019 +1200

Bug 1843149: Bulk import doesn't retain user details correctly

This change does the following:
- Gets rid of the static cache that was created during run
of the first record which would only save the first user's info.
- when username is taken, append numbers and not underscores
- get rid of the warning using count on globals var that were not
previously set to array()s.
- respects the email users about their accounts option

behatnotneeded

Change-Id: I57b1c5e4d401028defda0c35bfc8347149094eb2
Signed-off-by: Lisa Seeto <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10387

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/10387
Committed: https://git.mahara.org/mahara/mahara/commit/14bffe511334ae3b9c2b5daf4cd26687322319d5
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 14bffe511334ae3b9c2b5daf4cd26687322319d5
Author: Lisa Seeto <email address hidden>
Date: Thu Sep 12 12:08:59 2019 +1200

Bug 1843149: Bulk import doesn't retain user details correctly

This change does the following:
- Gets rid of the static cache that was created during run
of the first record which would only save the first user's info.
- when username is taken, append numbers and not underscores
- get rid of the warning using count on globals var that were not
previously set to array()s.
- respects the email users about their accounts option

behatnotneeded

Change-Id: I57b1c5e4d401028defda0c35bfc8347149094eb2
Signed-off-by: Lisa Seeto <email address hidden>
(cherry picked from commit 9dc7cbc6a3a6ecdaf132888c6d755a5af20496b7)