Should not display 'registered users' option on profile page view access when isolated institutions are on

Bug #1836981 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned
19.04
Fix Released
High
Unassigned
19.10
Fix Released
High
Unassigned

Bug Description

To test:

1) have an existing site with some users in an institution
2) turn isolated institutions on
3) log in as a user and go to Create -> Pages and collections
4) click on the access icon on the profile page
- you should see access rules for 'registered users' and the institution
5) on clicking on 'Manage access' you see the access page and the 'registered users' line is not set correctly

This is because with isolated institutions you can share with 'registered users'

Will make a patch to stop this access rule showing

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10179

Revision history for this message
Steven (stevens-q) wrote :

Commit hash: 785ec7741fcbc77ec2bb85a52a6b52064d01529b
Environment tested: Master
Browser tested: Chrome
Theme used: Raw

PRECONDITIONS:
------------------------
1)have an existing site with some users in an institution
2) turn isolated institutions on

TEST STEPS:
------------------------
1) Log in as a user and go to Create -> Pages and collections
2) Click on the access icon on the profile page
3) Verify user should see access rules for 'registered users' and the institution ✔

NOTE: This is because with isolated institutions you can share with 'registered users'

Catalyst QA Approved ✔

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10179
Committed: https://git.mahara.org/mahara/mahara/commit/785ec7741fcbc77ec2bb85a52a6b52064d01529b
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 785ec7741fcbc77ec2bb85a52a6b52064d01529b
Author: Robert Lyon <email address hidden>
Date: Thu Jul 18 12:36:11 2019 +1200

Bug 1836981: Don't show 'registered users' rule on view index page

And don't show the rule when editing the profile access when isolated
institutions are on

behatnotneeded

Change-Id: I4c3957a6c1efd2d515418ac31ff0c235356f1ce4
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10232

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10232
Committed: https://git.mahara.org/mahara/mahara/commit/9bf95dd27ea9d33cd9319dc8a49db06db3b26b55
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 9bf95dd27ea9d33cd9319dc8a49db06db3b26b55
Author: Robert Lyon <email address hidden>
Date: Thu Jul 18 12:36:11 2019 +1200

Bug 1836981: Don't show 'registered users' rule on view index page

And don't show the rule when editing the profile access when isolated
institutions are on

behatnotneeded

Change-Id: I4c3957a6c1efd2d515418ac31ff0c235356f1ce4
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 785ec7741fcbc77ec2bb85a52a6b52064d01529b)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.