Headings and sub-headings not displaying properly in SmartEvidence

Bug #1833158 reported by Rebecca Blundell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Rebecca Blundell
19.04
Fix Released
Medium
Unassigned
19.10
Fix Released
Medium
Rebecca Blundell

Bug Description

The SmartEvidence pages accessed from the admin menu, should show the following headings, but they show just 'SmartEvidence':

http://mahara/module/framework/frameworks.php
Management | SmartEvidence

http://mahara/module/framework/frameworks.php?upload=1
Editor | SmartEvidence

http://mahara/module/framework/frameworks.php?uploadmatrix=1
Import | SmartEvidence

This is because SUBSECTIONHEADING was not assigned correctly in htdocs/module/frameworks.php

To test the fix, check the above urls display the above titles

Changed in mahara:
assignee: nobody → Rebecca Blundell (rjb-dev)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/10094

Revision history for this message
Steven (stevens-q) wrote :

Commit hash: 19fba6757a3a93cc04d71301e4cf1ee111bdd539
Environment tested: Master
Browser tested: Chrome
Theme used: Raw

PRECONDITIONS:
------------------------
1) n/a

TEST STEPS:
------------------------
1) Log in as Site admin
2) Browse to Admin menu > Extensions > SmartEvidence
3) User click the Management tab
4) Verify that the page section h1 heading has the following text "Management | SmartEvidence" ✔
5) User click the Editor tab
6) Verify that the page section heading has the following text "Editor | SmartEvidence" ✔
7) User click the Import tab
8) Verify that the page section heading has the following text "Upload | SmartEvidence" ✔

Catalyst QA Approved ✔

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10094
Committed: https://git.mahara.org/mahara/mahara/commit/e86afa788b0e954cb6987ec8be54af4cd029af4e
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit e86afa788b0e954cb6987ec8be54af4cd029af4e
Author: Rebecca Blundell <email address hidden>
Date: Tue Jun 18 15:21:00 2019 +1200

Bug 1833158: Fix sub-headings in SmartEvidence

added correct sub-headings

behatnotneeded

Change-Id: I06ef9fc0c0c3d69996ecf5f68f033400181628df

Robert Lyon (robertl-9)
Changed in mahara:
status: New → Fix Committed
importance: Undecided → Medium
milestone: none → 19.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10241

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/10241
Committed: https://git.mahara.org/mahara/mahara/commit/6ff3e3d5010ce71e4b4f4a1c28bc524b3a16c962
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 6ff3e3d5010ce71e4b4f4a1c28bc524b3a16c962
Author: Rebecca Blundell <email address hidden>
Date: Tue Jun 18 15:21:00 2019 +1200

Bug 1833158: Fix sub-headings in SmartEvidence

added correct sub-headings

behatnotneeded

Change-Id: I06ef9fc0c0c3d69996ecf5f68f033400181628df
(cherry picked from commit e86afa788b0e954cb6987ec8be54af4cd029af4e)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.