Mahara

Upgrade cookie consent to 3.1.0

Series 19.04
Bug #1811141

Bug #1811141 reported by Robert Lyon on 2019-01-09

256

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Mahara	Fix Released	High	Robert Lyon	Mahara 19.04.0
17.10	Fix Released	High	Unassigned	Mahara 17.10.8
18.04	Fix Released	High	Unassigned	Mahara 18.04.4
18.10	Fix Released	High	Unassigned	Mahara 18.10.1
19.04	Fix Released	High	Robert Lyon	Mahara 19.04.0

Bug Description

Need to upgrade to take advantage of secure cookie flag

Robert Lyon (robertl-9) on 2019-01-09

Changed in mahara:
assignee:	nobody → Robert Lyon (robertl-9)
milestone:	none → 19.04.0

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2019-01-09: A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9407

Revision history for this message

Steven (stevens-q) wrote on 2019-01-27:

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) Site admin user exists
2) Cookie consent currently not enabled

TEST STEPS:
------------------------ Environment tested: Master
Browser tested: Chrome

PRECONDITIONS:
------------------------
1) Site admin user exists
2) Cookie consent currently not enabled

TEST STEPS:
------------------------
1) User log in as Site admin user
2) Browse to Admin menu > Configure site > Cookie Consent
3) User set the "Enable Cookie Consent" toggle to yes
4) Click the save button
5) Confirm a pop up modal is displayed at the bottom of the page ✔
--- a) Note down the wording of the message, links in the message and colour and the "Got it!" button colour to close modal
6) Add the patch to the code base - ensure that make CSS has run or the changes will not appear
7) Follow the above Test script steps
8) Confirm that the wording of the message, links in the message and the "Got it!" button colour have not changed ✘

Catalyst QA Failed Testing ✘

NOTES:
-------------------
"Got it!" Button background colour has changed from yellow to black and has an olive green boarder outlining the button. The text colour is also an olive green (#556d32)

1) 3.62:1 contrast ratio fails AA standard
1) User log in as Site admin user
2) Browse to Admin menu > Configure site > Cookie Consent
3) User set the "Enable Cookie Consent" toggle to yes
4) Click the save button
5) Confirm a pop up modal is displayed at the bottom of the page ✔
--- a) Note down the wording of the message, links in the message and colour and the "Got it!" button colour to close modal
6) Add the patch to the code base - ensure that make CSS has run or the changes will not appear
7) Follow the above Test script steps
8) Confirm that the wording of the message, links in the message and the "Got it!" button colour have not changed ✘

Catalyst QA Failed Testing ✘

NOTES:
-------------------
"Got it!" Button background colour has changed from yellow to black and has an olive green boarder outlining the button. The text colour is also an olive green (#556d32)

1) 3.62:1 contrast ratio fails AA standard

Environment tested: Master
Browser tested: Chrome

PRECONDITIONS: 
------------------------ 
1) Site admin user exists 
2) Cookie consent currently not enabled

TEST STEPS: 
------------------------ Environment tested: Master
Browser tested: Chrome

PRECONDITIONS: 
------------------------ 
1) Site admin user exists 
2) Cookie consent currently not enabled

TEST STEPS: 
------------------------ 
1) User log in as Site admin user
2) Browse to Admin menu > Configure site > Cookie Consent 
3) User set the "Enable Cookie Consent" toggle to yes 
4) Click the save button 
5) Confirm a pop up modal is displayed at the bottom of the page ✔
--- a) Note down the wording of the message, links in the message and colour and the "Got it!" button colour to close modal
6) Add the patch to the code base - ensure that make CSS has run or the changes will not appear
7) Follow the above Test script steps 
8) Confirm that the wording of the message, links in the message and the "Got it!" button colour have not changed ✘

Catalyst QA Failed Testing ✘

NOTES:
-------------------
"Got it!" Button background colour has changed from yellow to black and has an olive green boarder outlining the button. The text colour is also an olive green (#556d32)

1) 3.62:1 contrast ratio fails AA standard
1) User log in as Site admin user
2) Browse to Admin menu > Configure site > Cookie Consent 
3) User set the "Enable Cookie Consent" toggle to yes 
4) Click the save button 
5) Confirm a pop up modal is displayed at the bottom of the page ✔
--- a) Note down the wording of the message, links in the message and colour and the "Got it!" button colour to close modal
6) Add the patch to the code base - ensure that make CSS has run or the changes will not appear
7) Follow the above Test script steps 
8) Confirm that the wording of the message, links in the message and the "Got it!" button colour have not changed ✘

Catalyst QA Failed Testing ✘

NOTES:
-------------------
"Got it!" Button background colour has changed from yellow to black and has an olive green boarder outlining the button. The text colour is also an olive green (#556d32)

1) 3.62:1 contrast ratio fails AA standard

Revision history for this message

Steven (stevens-q) wrote on 2019-01-28:

Bug fixed - the wording of the message, links in the message and the "Got it!" button colour have not change ✔

Catalyst QA Approved ✔

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2019-01-29: A change has been merged

Reviewed: https://reviews.mahara.org/9407
Committed: https://git.mahara.org/mahara/mahara/commit/9a82762741303de8f134ee24b79e63600636276c
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 9a82762741303de8f134ee24b79e63600636276c
Author: Robert Lyon <email address hidden>
Date: Thu Jan 10 09:32:52 2019 +1300

Bug 1811141: upgrade cookie consent library to v3.1.0

behatnotneeded

Change-Id: Id5553a18d47d3b2d94e2b0ba7c06d5ea9715ebe0
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2019-01-29: A patch has been submitted for review

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9490

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2019-01-29: A change has been merged

Reviewed: https://reviews.mahara.org/9490
Committed: https://git.mahara.org/mahara/mahara/commit/f63d8cdb86bd5fddb5d2f6d31c2ec2cfc020703f
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.10_STABLE

commit f63d8cdb86bd5fddb5d2f6d31c2ec2cfc020703f
Author: Robert Lyon <email address hidden>
Date: Thu Jan 10 09:32:52 2019 +1300

Bug 1811141: upgrade cookie consent library to v3.1.0

behatnotneeded

Change-Id: Id5553a18d47d3b2d94e2b0ba7c06d5ea9715ebe0
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 9a82762741303de8f134ee24b79e63600636276c)

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2019-01-29: A patch has been submitted for review

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/9494

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2019-01-29:

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/9495

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2019-01-30: A change has been merged

Reviewed: https://reviews.mahara.org/9494
Committed: https://git.mahara.org/mahara/mahara/commit/3b1c83e103fca038f2bb271aaaf41b1504b08dbe
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.04_STABLE

commit 3b1c83e103fca038f2bb271aaaf41b1504b08dbe
Author: Robert Lyon <email address hidden>
Date: Thu Jan 10 09:32:52 2019 +1300

Bug 1811141: upgrade cookie consent library to v3.1.0

behatnotneeded

Change-Id: Id5553a18d47d3b2d94e2b0ba7c06d5ea9715ebe0
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 9a82762741303de8f134ee24b79e63600636276c)

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2019-01-30:

#10

Reviewed: https://reviews.mahara.org/9495
Committed: https://git.mahara.org/mahara/mahara/commit/dd340a5b7e66521f85761ae4ff25bed91711c55b
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.10_STABLE

commit dd340a5b7e66521f85761ae4ff25bed91711c55b
Author: Robert Lyon <email address hidden>
Date: Thu Jan 10 09:32:52 2019 +1300

Bug 1811141: upgrade cookie consent library to v3.1.0

behatnotneeded

Change-Id: Id5553a18d47d3b2d94e2b0ba7c06d5ea9715ebe0
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 9a82762741303de8f134ee24b79e63600636276c)

Report a bug

This report contains Public Security information

Everyone can see this security related information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.