Mahara

javascript syntax error when editing forum topic

  1. Series 19.04
  2. Bug #1803616
Bug #1803616 reported by Cecilia Vela Gurovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Low
Robert Lyon
Mahara 18.10.1
18.10
Fix Released
Low
Robert Lyon
Mahara 18.10.1
19.04
Fix Released
Low
Unassigned
Mahara 19.04.0

Bug Description

Error displayed in browser console:

SyntaxError: expected expression, got ';'

To reproduce:
 - In Admin menu -> Extensions -> Plugin Admin
find forum settings and set 'Post display' to 1
 - In a group, create a forum topic
 - Open the edit topic screen
 - Wait 1 minute and refresh the page
 - in the browser's console we can see the error message is displayed

Revision history for this message
Cecilia Vela Gurovic (ceciliavg) wrote :

https://reviews.mahara.org/#/c/9311/

Changed in mahara:
status: New → Confirmed
milestone: none → 19.04.0
assignee: nobody → Robert Lyon (robertl-9)
importance: Undecided → Low
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9311
Committed: https://git.mahara.org/mahara/mahara/commit/b35960b0c1452344199a41ce24d5d13bc4ba898e
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit b35960b0c1452344199a41ce24d5d13bc4ba898e
Author: Robert Lyon <email address hidden>
Date: Thu Nov 15 13:13:00 2018 +1300

Bug 1803616: SyntaxError: expected expression, got ';'

Needing to check if we have $timeleft before displaying the js for it

behatnotneeded
Change-Id: I7ac1b4fd31238b51e5e2200b37f4aed2cd275eec
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9318

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9318
Committed: https://git.mahara.org/mahara/mahara/commit/f558daa55beefde0ea92ef027b62c6a0fc26f2ce
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit f558daa55beefde0ea92ef027b62c6a0fc26f2ce
Author: Robert Lyon <email address hidden>
Date: Thu Nov 15 13:13:00 2018 +1300

Bug 1803616: SyntaxError: expected expression, got ';'

Needing to check if we have $timeleft before displaying the js for it

behatnotneeded
Change-Id: I7ac1b4fd31238b51e5e2200b37f4aed2cd275eec
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit b35960b0c1452344199a41ce24d5d13bc4ba898e)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9321

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9321
Committed: https://git.mahara.org/mahara/mahara/commit/05aaf2c0082841fd6f1867d12fcdda2295c24733
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit 05aaf2c0082841fd6f1867d12fcdda2295c24733
Author: Steven Spinelli <email address hidden>
Date: Tue Nov 20 12:05:52 2018 +1300

Behat Bug 1804074 Adding journal entry from Journal block on page
Merge branch 'master' of https://git.mahara.org/mahara/mahara

* 'master' of https://git.mahara.org/mahara/mahara:
Bug 1803616: SyntaxError: expected expression, got ';'
Bug 1802180: Have a simplified group update webservice option
Bug 1800422: Fixed z-index for custom-dropdown
Bug 1803194: Need to include the user object
Bug 1802205: All external links to be opened in new tab/window by default

Change-Id: Ibe0898d9326c0527cc6a4e937da9782b00c10eb0

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.