Goals and skills - add file - after preview focus lost on the pop-up with my files

Bug #1817326 reported by Aurelien Besson on 2019-02-22
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
18.04
Medium
Unassigned
18.10
Medium
Unassigned

Bug Description

I'am in Goals and skills.

I add file, a new window open with my files, if i click of one of them a preview pop-up open. If a click on the side, this pop close, but the focus was lost on the windows who display my files. The scrolling it's on the main page not on the first open pop-up (list of my files).

If you want to reproduice the bug, you should have many files (+ 10) in your bank.

I hope to be clear to explain the bug.

Thank you

- Mahara 18.10
- Windows 10 (web server on linux)
- Mysql Database
- Google Chrome

Aurelien Besson (abesson) wrote :

Thank you for the report. This is not a bug in Mahara. When you click outside of the preview window it takes you back to the main Mahara page rather than the file list. When you click on "Add file" again, it takes you back to where you left off and you can click the "Close" button.

Changed in mahara:
status: New → Won't Fix
Aurelien Besson (abesson) wrote :

Sorry, but I think we are misunderstood.

This is really a bug, to reproduce it:
- in Goals and skills | Summary page click on "Add a file"
- add a lot of files so that the window must be longer than the screen
- view an image, and click outside the visualization
- you can see that it is impossible to scroll in the window that displays the list of images (the focus has returned to the page back)

Thank you for looking at the attached gif that shows exactly the problem.

Changed in mahara:
status: Won't Fix → New
Kevin Dibble (digitalskill) wrote :

Modal in a Modal popup:
This issue does not affect 19.04.

In 18.10 the modal of the image preview is appearing inside another Modal. Clicking "Close" on the popup closes all Modals.

The second Modal inherits the size of the first modal box (rather than sitting on the viewport) creating incorrect heights on the image that appears - meaning that scrolling needs to occur to view the image if scrolled down the page.

The fix would be to add the modal template call to the bottom of the modal page for viewing files.

Changed in mahara:
status: New → In Progress
assignee: nobody → Kevin Dibble (digitalskill)
Robert Lyon (robertl-9) on 2019-05-01
Changed in mahara:
milestone: none → 18.10.2
milestone: 18.10.2 → none
Mahara Bot (dev-mahara) wrote :

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9941

no longer affects: mahara
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/10112

Reviewed: https://reviews.mahara.org/10112
Committed: https://git.mahara.org/mahara/mahara/commit/9bd277e5257e498119be95489db4107231e4f13c
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 9bd277e5257e498119be95489db4107231e4f13c
Author: Robert Lyon <email address hidden>
Date: Fri Jun 21 11:29:13 2019 +1200

Bug 1817326: Modal in a Modal popup problem

When closing the inner modal it removes a class from the <body> tag
causing the scrolling to break

behatnotneeded

Change-Id: I9d132a91cd48500276951c24c0987b418daacb6e
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/10113
Committed: https://git.mahara.org/mahara/mahara/commit/5bff19e5e7b7ec59e9b8afd9ce3f865a1895498a
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 5bff19e5e7b7ec59e9b8afd9ce3f865a1895498a
Author: Robert Lyon <email address hidden>
Date: Fri Jun 21 11:35:18 2019 +1200

Bug 1817326: Modal in a Modal popup problem for editcomposite

When closing the inner modal it removes a class from the <body> tag
causing the scrolling to break

behatnotneeded

Change-Id: Ic7d6678a6d69d57343678f1ca57e8fa2e00861e2
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Patch for "19.04_STABLE" branch: https://reviews.mahara.org/10115

Mahara Bot (dev-mahara) wrote :

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/10116

Mahara Bot (dev-mahara) wrote :

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/10117

Reviewed: https://reviews.mahara.org/10117
Committed: https://git.mahara.org/mahara/mahara/commit/757ba5e6b90888ba0e219afd010d50b3931b230e
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit 757ba5e6b90888ba0e219afd010d50b3931b230e
Author: Robert Lyon <email address hidden>
Date: Fri Jun 21 11:35:18 2019 +1200

Bug 1817326: Modal in a Modal popup problem for editcomposite

When closing the inner modal it removes a class from the <body> tag
causing the scrolling to break

behatnotneeded

Change-Id: Ic7d6678a6d69d57343678f1ca57e8fa2e00861e2
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 5bff19e5e7b7ec59e9b8afd9ce3f865a1895498a)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10116
Committed: https://git.mahara.org/mahara/mahara/commit/cea4728fa91500f1b0b9cc264d8c7830b2978707
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.10_STABLE

commit cea4728fa91500f1b0b9cc264d8c7830b2978707
Author: Robert Lyon <email address hidden>
Date: Fri Jun 21 11:29:13 2019 +1200

Bug 1817326: Modal in a Modal popup problem

When closing the inner modal it removes a class from the <body> tag
causing the scrolling to break

behatnotneeded

Change-Id: I9d132a91cd48500276951c24c0987b418daacb6e
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 9bd277e5257e498119be95489db4107231e4f13c)

Mahara Bot (dev-mahara) wrote :

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/10119

Reviewed: https://reviews.mahara.org/10119
Committed: https://git.mahara.org/mahara/mahara/commit/2f6f8f06f602668a9177f15460670c8df5411ee7
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit 2f6f8f06f602668a9177f15460670c8df5411ee7
Author: Robert Lyon <email address hidden>
Date: Fri Jun 21 11:35:18 2019 +1200

Bug 1817326: Modal in a Modal popup problem for editcomposite

When closing the inner modal it removes a class from the <body> tag
causing the scrolling to break

behatnotneeded

Change-Id: Ic7d6678a6d69d57343678f1ca57e8fa2e00861e2
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 5bff19e5e7b7ec59e9b8afd9ce3f865a1895498a)
(cherry picked from commit 757ba5e6b90888ba0e219afd010d50b3931b230e)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10118
Committed: https://git.mahara.org/mahara/mahara/commit/af790cac5f45fedf680b79b3f89053ee6b3a75ca
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit af790cac5f45fedf680b79b3f89053ee6b3a75ca
Author: Robert Lyon <email address hidden>
Date: Fri Jun 21 11:29:13 2019 +1200

Bug 1817326: Modal in a Modal popup problem

When closing the inner modal it removes a class from the <body> tag
causing the scrolling to break

behatnotneeded

Change-Id: I9d132a91cd48500276951c24c0987b418daacb6e
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 9bd277e5257e498119be95489db4107231e4f13c)
(cherry picked from commit cea4728fa91500f1b0b9cc264d8c7830b2978707)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10114
Committed: https://git.mahara.org/mahara/mahara/commit/594184f10f9c20186944c598f11c0fa3b4b48501
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit 594184f10f9c20186944c598f11c0fa3b4b48501
Author: Robert Lyon <email address hidden>
Date: Fri Jun 21 11:29:13 2019 +1200

Bug 1817326: Modal in a Modal popup problem

When closing the inner modal it removes a class from the <body> tag
causing the scrolling to break

behatnotneeded

Change-Id: I9d132a91cd48500276951c24c0987b418daacb6e
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 9bd277e5257e498119be95489db4107231e4f13c)

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/10115
Committed: https://git.mahara.org/mahara/mahara/commit/b8532ff6cc5e7ff78586ca01df1c25ba6b28d1d2
Submitter: Robert Lyon (<email address hidden>)
Branch: 19.04_STABLE

commit b8532ff6cc5e7ff78586ca01df1c25ba6b28d1d2
Author: Robert Lyon <email address hidden>
Date: Fri Jun 21 11:35:18 2019 +1200

Bug 1817326: Modal in a Modal popup problem for editcomposite

When closing the inner modal it removes a class from the <body> tag
causing the scrolling to break

behatnotneeded

Change-Id: Ic7d6678a6d69d57343678f1ca57e8fa2e00861e2
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit 5bff19e5e7b7ec59e9b8afd9ce3f865a1895498a)

Robert Lyon (robertl-9) wrote :

Hmm, the issue seems to exist in 19.10 and below - the problem looks to be the fact that when the inner modal is closed when clicking outside it - it removes a class from 'body' of the page that scrolling within the outer modal relies on

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers