Wall posts to other users not sending notification
Bug #1813200 reported by
Robert Lyon
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
High
|
Robert Lyon | ||
17.10 |
Fix Released
|
High
|
Unassigned | ||
18.04 |
Fix Released
|
High
|
Unassigned | ||
18.10 |
Fix Released
|
High
|
Unassigned | ||
19.04 |
Fix Released
|
High
|
Robert Lyon |
Bug Description
When user A is leaving a wall post on another user B's profile page a notification is sent to user B
But after the first few messages the following bug occurs.
When posting to the wall the button switches from "Post" to "processing" - but doesn't finish processing.
On refresh of the page the new post exists.
So there is a problem with the process updating the page without reload.
Changed in mahara: | |
assignee: | nobody → Robert Lyon (robertl-9) |
milestone: | none → 19.04.0 |
importance: | Undecided → High |
status: | New → In Progress |
tags: | added: regression |
To post a comment you must log in.
Turns out the problem is related to the information we give to the notification activity that happens after the new post is saved.
We accidentally supply the new wall post's id as the 'id' property in the activity $data class and the activity class confuses that id with an activity_type id.
So when the post id is a low number it can match with a real activity_type id and email is sent but in one's inbox it shows the wall post message with wrong activity type. They should all have the " icon - the circled one in attached image.
And when a wall post id is higher than any possible activity_type id then the 'processing...' error occurs.
We should strip out the wall post id from the object being sent to activity class