Mahara

Equation editor will not load in HTTPS

Series 18.10
Bug #1811284

Bug #1811284 reported by Doug Stevens on 2019-01-10

This bug affects 4 people

	Status	Importance	Assigned to	Milestone
Mahara	Fix Released	High	Unassigned	Mahara 19.04.0
17.10	Fix Released	High	Unassigned	Mahara 17.10.8
18.04	Fix Released	High	Unassigned	Mahara 18.04.4
18.10	Fix Released	High	Unassigned	Mahara 18.10.1
19.04	Fix Released	High	Unassigned	Mahara 19.04.0

Bug Description

Opening the TinyMCE equation editor in 18.10.0 does not display. Console (Google Chrome) displays:

Mixed Content: The page at 'https://mahara.fsd38.ab.ca/artefact/artefact.php?view=14436&artefact=66008' was loaded over HTTPS, but requested an insecure script 'http://yui.yahooapis.com/3.14.1/build/yui/yui-min.js'. This request has been blocked; the content must be served over HTTPS.
mathslate.html:14 Mixed Content: The page at 'https://mahara.fsd38.ab.ca/artefact/artefact.php?view=14436&artefact=66008' was loaded over HTTPS, but requested an insecure stylesheet 'http://./styles.css'. This request has been blocked; the content must be served over HTTPS.
mathslate.html:17 Uncaught ReferenceError: YUI is not defined
    at mathslate.html:17
moodle-tinymce_mathslate-snippeteditor-debug.js:1 Uncaught ReferenceError: YUI is not defined
    at moodle-tinymce_mathslate-snippeteditor-debug.js:1
moodle-tinymce_mathslate-mathjaxeditor-debug.js:1 Uncaught ReferenceError: YUI is not defined
    at moodle-tinymce_mathslate-mathjaxeditor-debug.js:1
moodle-tinymce_mathslate-editor-debug.js:1 Uncaught ReferenceError: YUI is not defined
    at moodle-tinymce_mathslate-editor-debug.js:1
moodle-tinymce_mathslate-textool-debug.js:1 Uncaught ReferenceError: YUI is not defined
    at moodle-tinymce_mathslate-textool-debug.js:1
mathslate.html:42 Uncaught ReferenceError: YUI is not defined
    at mathslate.html:42
mathslate.html:1 Mixed Content: The page at 'https://mahara.fsd38.ab.ca/artefact/artefact.php?view=14436&artefact=66008' was loaded over HTTPS, but requested an insecure stylesheet 'http://./styles.css'. This request has been blocked; the content must be served over HTTPS.

Tags:

Revision history for this message

Doug Stevens (physmatical) wrote on 2019-01-10:

Screen Shot 2019-01-10 at 1.23.57 PM.png Edit (39.8 KiB, image/png)

Robert Lyon (robertl-9) on 2019-01-29

Changed in mahara:
status:	New → Confirmed
importance:	Undecided → High

Revision history for this message

Robert Lyon (robertl-9) wrote on 2019-01-29:

The problem here is the tinymce plugin relies on the YUI library and that is currently being served externally via http:// and not https://

I'll update the plugin so that it fetches the https:// version of the external files if mahara site is using https://

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2019-01-29: A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/9499

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2019-02-07: A change has been merged

Reviewed: https://reviews.mahara.org/9499
Committed: https://git.mahara.org/mahara/mahara/commit/b8b97d1e19ddf7e912bdda9b6013854cead07f00
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit b8b97d1e19ddf7e912bdda9b6013854cead07f00
Author: Robert Lyon <email address hidden>
Date: Wed Jan 30 12:56:21 2019 +1300

Bug 1811284: Allow mathslate to work in https sites

Currently the template file for this has hardcoded http urls
We need to use a different template if the mahara site is https://

behatnotneeded

Change-Id: I6fbdf769efcbbafdf68af8b075573ba14ea16f43
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2019-02-07: A patch has been submitted for review

Patch for "18.10_STABLE" branch: https://reviews.mahara.org/9529

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2019-02-07:

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/9530

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2019-02-07:

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/9531

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2019-02-07: A change has been merged

Reviewed: https://reviews.mahara.org/9529
Committed: https://git.mahara.org/mahara/mahara/commit/0201d72c9f546c38662e1ae6487d683b3c36425a
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.10_STABLE

commit 0201d72c9f546c38662e1ae6487d683b3c36425a
Author: Robert Lyon <email address hidden>
Date: Wed Jan 30 12:56:21 2019 +1300

Bug 1811284: Allow mathslate to work in https sites

Currently the template file for this has hardcoded http urls
We need to use a different template if the mahara site is https://

behatnotneeded

Change-Id: I6fbdf769efcbbafdf68af8b075573ba14ea16f43
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit b8b97d1e19ddf7e912bdda9b6013854cead07f00)

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2019-02-07:

Reviewed: https://reviews.mahara.org/9530
Committed: https://git.mahara.org/mahara/mahara/commit/71125b0d6b8999097f8367e50b4f077e5368f35b
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.04_STABLE

commit 71125b0d6b8999097f8367e50b4f077e5368f35b
Author: Robert Lyon <email address hidden>
Date: Wed Jan 30 12:56:21 2019 +1300

Bug 1811284: Allow mathslate to work in https sites

Currently the template file for this has hardcoded http urls
We need to use a different template if the mahara site is https://

behatnotneeded

Change-Id: I6fbdf769efcbbafdf68af8b075573ba14ea16f43
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit b8b97d1e19ddf7e912bdda9b6013854cead07f00)

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2019-02-07:

#10

Reviewed: https://reviews.mahara.org/9531
Committed: https://git.mahara.org/mahara/mahara/commit/57d18251f1731df1696d6d437e16708598178974
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.10_STABLE

commit 57d18251f1731df1696d6d437e16708598178974
Author: Robert Lyon <email address hidden>
Date: Wed Jan 30 12:56:21 2019 +1300

Bug 1811284: Allow mathslate to work in https sites

Currently the template file for this has hardcoded http urls
We need to use a different template if the mahara site is https://

behatnotneeded

Change-Id: I6fbdf769efcbbafdf68af8b075573ba14ea16f43
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit b8b97d1e19ddf7e912bdda9b6013854cead07f00)