Mahara

Select2 tag selector is not positioning correctly

Series 18.04
Bug #1767887

Bug #1767887 reported by Robert Lyon on 2018-04-29

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Mahara	Fix Released	High	Unassigned	Mahara 18.10.0
18.04	Fix Released	High	Unassigned	Mahara 18.04.1
18.10	Fix Released	High	Unassigned	Mahara 18.10.0

Bug Description

The place that does the search / selection should be below the selected options box but now it floats off above the box - see screenshots

Revision history for this message

Robert Lyon (robertl-9) wrote on 2018-04-29:

Normal Edit (7.7 KiB, image/png)

Revision history for this message

Robert Lyon (robertl-9) wrote on 2018-04-29:

Broken Edit (7.2 KiB, image/png)

Changed in mahara:
importance:	Undecided → High
milestone:	none → 18.10.0

Revision history for this message

Robert Lyon (robertl-9) wrote on 2018-04-29:

This got broken by Bug 1698257: Make header height adjustable using navbar-height variable with patch https://reviews.mahara.org/#/c/8687/3

Revision history for this message

Robert Lyon (robertl-9) wrote on 2018-04-30:

This looks to be due to the change in htdocs/theme/raw/sass/form/_site-messages.scss

        + .main-content {
            @media (min-width: $screen-sm-min) {
                margin-top: $navbar-height + ($i * 33px);
            }
        }

As it produces something like (when there are 2 site messages):

@media (min-width:768px) {
.header.message-count-2+.main-content{margin-top:126px}
}

And the positioning of the selector dropdown is 126px out of alignment

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2018-04-30: A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8817

Revision history for this message

Steven (stevens-q) wrote on 2018-05-16: Re: Select2 tag secector is not positioning correctly

Launchpad: https://bugs.launchpad.net/mahara/+bug/1767887
Gerrit: https://reviews.mahara.org/#/c/8817/
Bug description: Select2 tag secector is not positioning correctly Edit
--------------------------------------------------------------
Environment tested: Master
Browser tested: Chrome

===================
Manual Test Script
===================

Preconditions:

1. User has used the following tags
  a. tag1
  b. tag 2
  c. tag
2. The mahara site theme is set to "Raw"

Test Script: checking tags fields for correct functionality
------------------------------------------------------------

1. Log in as authenticated user
2. Browse to Main menu > Portfolio > Pages and collections
3. Add a new page - fill in required fields
4. Type "tag1" in the "Tags" field
5. Confirm the field auto suggest displays the suggestion under the Tags field ✔
6. Confirm the background colour for the current suggestion is green ✔
7. Browse to Main menu > Content > Files
8. Enter a folder name and create a new folder
9. Edit the folder by cliclking the pencil icon to right of folder
10. Type "tag1" in the "Tags" field
11. Confirm the field auto suggest displays the suggestion under the Tags field ✔
12. Confirm the background colour for the current suggestion is green ✔

Catalyst QA Approved ✔

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2018-05-16: A change has been merged

Reviewed: https://reviews.mahara.org/8817
Committed: https://git.mahara.org/mahara/mahara/commit/f28839c65a85c3a7d76c6075be4a61db90a2ea9f
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit f28839c65a85c3a7d76c6075be4a61db90a2ea9f
Author: Robert Lyon <email address hidden>
Date: Mon Apr 30 12:22:18 2018 +1200

Bug 1767887: Problem with body having offset value for select2

Before the change in Bug 1698257 the offset of <body> was 0 but now it
is the height of the site messages + navbar

behatnotneeded

Change-Id: I6331f95d54eef4d159c7cc9731d48a0c9eb5d003
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2018-05-16: A patch has been submitted for review

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8862

Revision history for this message

Mahara Bot (dev-mahara) wrote on 2018-05-16: A change has been merged

Reviewed: https://reviews.mahara.org/8862
Committed: https://git.mahara.org/mahara/mahara/commit/c3fe37d1b452783c2c184204d6c86613ff4ccf55
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit c3fe37d1b452783c2c184204d6c86613ff4ccf55
Author: Robert Lyon <email address hidden>
Date: Mon Apr 30 12:22:18 2018 +1200

Bug 1767887: Problem with body having offset value for select2

Before the change in Bug 1698257 the offset of <body> was 0 but now it
is the height of the site messages + navbar

behatnotneeded

Change-Id: I6331f95d54eef4d159c7cc9731d48a0c9eb5d003
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit f28839c65a85c3a7d76c6075be4a61db90a2ea9f)

Kristina Hoeppner (kris-hoeppner) on 2018-05-16

summary:

- Select2 tag secector is not positioning correctly
+ Select2 tag selector is not positioning correctly