Setting up group when user is in 2 institutions and not site admin brings error

[Kristina Hoeppner]

master (18.04RC1)

When user is in two institutions but not the site admin, the following error message is displayed when she wants to set up a group:

[WAR] 3e (lib/pieforms/pieform.php:1343) Invalid value for select "institution"
Call stack (most recent first):

    log_message(string(size 38), integer, true, true, string(size 58), integer) at /home/kristina/code/mahara/htdocs/lib/errors.php:521
    error(integer, string(size 38), string(size 58), integer, array(size 2)) at Unknown:0
    trigger_error(string(size 38), integer) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1343
    Pieform::info(string(size 38)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform/elements/select.php:151
    pieform_element_select(object(Pieform), array(size 10)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1509
    Pieform->build_element_html(array(size 10)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:725
    Pieform->build() at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:169
    Pieform::process(array(size 4)) at /home/kristina/code/mahara/htdocs/lib/mahara.php:5077
    pieform(array(size 4)) at /home/kristina/code/mahara/htdocs/group/edit.php:424

There is no error message when the user is in only one institution.

To replicate:

1. Make a user a member in 2 or more institutions.
2. Go to Main menu -> Groups -> My groups.
3. Click the "Create group" button.
Expected result: No error message.
Actual result: Above error message is displayed.

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/8658

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8658
Committed: https://git.mahara.org/mahara/mahara/commit/cdea3ba4a4ff2d09d3d7f12e8c687fbb8917ed9f
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit cdea3ba4a4ff2d09d3d7f12e8c687fbb8917ed9f
Author: Robert Lyon <email address hidden>
Date: Mon Mar 19 14:06:13 2018 +1300

Bug 1756631: Create group with relevant default institution set

If the user is in one or more true institutions they need the default
option set as that and not 'mahara'

behatnotneeded

Change-Id: If295f76c3dac0c1ae5d3dd1ec2346511b0645150
Signed-off-by: Robert Lyon <email address hidden>

[Mahara Bot (dev-mahara)]

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/8671

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/8671
Committed: https://git.mahara.org/mahara/mahara/commit/b78ce5707c78fc0c6bdc1c1f1d1c740e1325e67c
Submitter: Robert Lyon (<email address hidden>)
Branch: 18.04_STABLE

commit b78ce5707c78fc0c6bdc1c1f1d1c740e1325e67c
Author: Robert Lyon <email address hidden>
Date: Mon Mar 19 14:06:13 2018 +1300

Bug 1756631: Create group with relevant default institution set

If the user is in one or more true institutions they need the default
option set as that and not 'mahara'

behatnotneeded

Change-Id: If295f76c3dac0c1ae5d3dd1ec2346511b0645150
Signed-off-by: Robert Lyon <email address hidden>
(cherry picked from commit cdea3ba4a4ff2d09d3d7f12e8c687fbb8917ed9f)