Mahara

upgrade modernizr library to v3.6.0

  1. Series 17.10
  2. Bug #1779959
Bug #1779959 reported by Cecilia Vela Gurovic
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Cecilia Vela Gurovic
Mahara 18.10.0
17.04
Fix Released
Medium
Unassigned
Mahara 17.04.10
17.10
Fix Released
Medium
Unassigned
Mahara 17.10.7
18.04
Fix Released
Medium
Unassigned
Mahara 18.04.3

Bug Description

we need to upgrade modernizr library in js/jquery/modernizr.custom.js
from v2.6.2 to v3.6.0
https://github.com/Modernizr/Modernizr

also place the lib file outside jquery folder

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: New → Confirmed
Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
assignee: nobody → Cecilia Vela Gurovic (ceciliavg)
Revision history for this message
Cecilia Vela Gurovic (ceciliavg) wrote :

I think we are not using this lib anymore

in js/jquery there is a custom modernizr build containing functions:

addTest
load
mq
testStyles

searching the code, I couldnt find a call to any of these functions. There used to be a call to Modernizr.mq() but was removed in commit 74b5a5e0a5989670a48199413fb646a72170bc95
Page Builder and BUG fixes (bootstrap)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/8998

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8998
Committed: https://git.mahara.org/mahara/mahara/commit/a4c63b449580539c6dbbbac11089e7d8452f301a
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: master

commit a4c63b449580539c6dbbbac11089e7d8452f301a
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Jul 9 18:11:37 2018 +1200

Bug 1779959: removing modernizr lib not used anymore

behatnotneeded

Change-Id: I1f54b6d7649c1ff60661ba65cf0e1ac0d7c26af3

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
milestone: none → 18.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "18.04_STABLE" branch: https://reviews.mahara.org/9007

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9007
Committed: https://git.mahara.org/mahara/mahara/commit/79e3d7369a9888b75095487659788b61291f17cf
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 18.04_STABLE

commit 79e3d7369a9888b75095487659788b61291f17cf
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Jul 9 18:11:37 2018 +1200

Bug 1779959: removing modernizr lib not used anymore

behatnotneeded

Change-Id: I1f54b6d7649c1ff60661ba65cf0e1ac0d7c26af3
(cherry picked from commit a4c63b449580539c6dbbbac11089e7d8452f301a)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.10_STABLE" branch: https://reviews.mahara.org/9008

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9008
Committed: https://git.mahara.org/mahara/mahara/commit/3631b7fc33014cfa229f9e4817b7d718f1b4411b
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.10_STABLE

commit 3631b7fc33014cfa229f9e4817b7d718f1b4411b
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Jul 9 18:11:37 2018 +1200

Bug 1779959: removing modernizr lib not used anymore

behatnotneeded

Change-Id: I1f54b6d7649c1ff60661ba65cf0e1ac0d7c26af3
(cherry picked from commit a4c63b449580539c6dbbbac11089e7d8452f301a)
(cherry picked from commit 79e3d7369a9888b75095487659788b61291f17cf)

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/9009

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/9009
Committed: https://git.mahara.org/mahara/mahara/commit/092a7a1ad90f76fe8f62ff456ffe03cb55bcc738
Submitter: Cecilia Vela Gurovic (<email address hidden>)
Branch: 17.04_STABLE

commit 092a7a1ad90f76fe8f62ff456ffe03cb55bcc738
Author: Cecilia Vela Gurovic <email address hidden>
Date: Mon Jul 9 18:11:37 2018 +1200

Bug 1779959: removing modernizr lib not used anymore

behatnotneeded

Change-Id: I1f54b6d7649c1ff60661ba65cf0e1ac0d7c26af3
(cherry picked from commit a4c63b449580539c6dbbbac11089e7d8452f301a)
(cherry picked from commit 79e3d7369a9888b75095487659788b61291f17cf)

Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
importance: Undecided → Medium
Cecilia Vela Gurovic (ceciliavg)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.