"New entry" button doesn't work in "Tagged journal entries" block

Bug #1700689 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
High
Unassigned
17.04
Fix Released
High
Cecilia Vela Gurovic
17.10
Fix Released
High
Unassigned

Bug Description

Mahara 17.04+

The "New entry" / "Add" button doesn't work in the block "Tagged journal entries".

To replicate:

Scenario 1 to test

1. Create a journal entry with at least one tag.
2. Create a page and place the "Tagged journal entries" block on it.
3. Click the "New entry" button.

Expected result: You are taken to the page to create a new journal entry.
Actual result: Nothing happens.

Scenario 2 to test

1. Create another journal and add a journal entry to that with the same tag as in Scenario 1.
2. Reload the page in edit mode. You'll now see the "Add" button rather than the "New entry" button.
3. Select a journal and click the "Add" button.

Expected result: You are taken to the page to create a new journal entry.
Actual result: Nothing happens.

I suspect it's some JS regression as it works fine in 16.10.

Tags: regression
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :

This needs to be fixed before bug #1700690 is attempted.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/7845

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/7845
Committed: https://git.mahara.org/mahara/mahara/commit/81d85da6a5c2a9f13048acc2d10f4ca1cbc7c372
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 81d85da6a5c2a9f13048acc2d10f4ca1cbc7c372
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Jun 30 14:20:36 2017 +1200

Bug 1700689: fixed tagged posts "Add" button throwing exception

Add button functionality got broken when we removed Mochikit

behatnotneeded

Change-Id: Ibe5b26e0f314a6a69f0dee8d9d6b672fafbdb5d2

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7859

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7859
Committed: https://git.mahara.org/mahara/mahara/commit/eeaa19a5d312f921c2028c83e9528f29aa37f61e
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit eeaa19a5d312f921c2028c83e9528f29aa37f61e
Author: Cecilia Vela Gurovic <email address hidden>
Date: Fri Jun 30 14:20:36 2017 +1200

Bug 1700689: fixed tagged posts "Add" button throwing exception

Add button functionality got broken when we removed Mochikit

behatnotneeded

Change-Id: Ibe5b26e0f314a6a69f0dee8d9d6b672fafbdb5d2
(cherry picked from commit 81d85da6a5c2a9f13048acc2d10f4ca1cbc7c372)

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.