elasticsearch image thumbnail missing when viewing media shared by another

Bug #1716083 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon
17.04
Fix Released
Medium
Unassigned
17.10
Fix Released
Medium
Robert Lyon

Bug Description

Scenario: User A shares a page containing an image with User B

When user B searches for all things in Elasticsearch they can see the page listed under Portfolio tab and can see the image listed under the Media tab.

They however cannot see the thumbnail of the image.

There is a bit of code missing from the ElasticsearchType_artefact.php file. The bit of code that checks that we can see the artefact and the view is there. But the viewid is not passed to the get_icon() function.

This patch will add that missing bit in

Revision history for this message
Robert Lyon (robertl-9) wrote :

For 17.10 this will be handled by https://reviews.mahara.org/#/c/7913/18..19

Changed in mahara:
milestone: none → 17.10.0
milestone: 17.10.0 → 17.04.4
milestone: 17.04.4 → 17.10.0
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/8008

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/8008
Committed: https://git.mahara.org/mahara/mahara/commit/81273a93e35d4fa7b5591bc0691d156e1069d484
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 81273a93e35d4fa7b5591bc0691d156e1069d484
Author: Robert Lyon <email address hidden>
Date: Sat Sep 9 15:53:40 2017 +1200

Bug 1716083: Allow viewing of image thumb when on page we can view

In the results from elasticsearch.

behatnotneeded

Change-Id: I7a74ba6d85a6d1c47c244b3aa1e54e1c6134f519
Signed-off-by: Robert Lyon <email address hidden>

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.