When adding blank annotation via page editor it removes tinymce from field

Bug #1715260 reported by Robert Lyon on 2017-09-05
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mahara
High
Robert Lyon
16.10
High
Unassigned
17.04
High
Unassigned
17.10
High
Robert Lyon

Bug Description

Because the form is added again via viewmanager it doesn't have the tinymce started in it on form error return.

I'll add the code to rewire them back up.

----------

To test:
1) Enable annotation block via Admin -> Extensions
2) Create a page and add annotation block to it
3) Don't fill in anything in annotation field but hit 'save'
You should see the error 'This field is required.'

Before patch the field stops being a TinyMCe field and becomes a normal one

After patch (and hard refresh of javascript on page edit screen)

You should see the error 'This field is required.' and the field stay a tinyMCE field

Robert Lyon (robertl-9) on 2017-09-05
Changed in mahara:
milestone: none → 17.10.0
assignee: nobody → Robert Lyon (robertl-9)
importance: Undecided → High
status: New → In Progress
Robert Lyon (robertl-9) wrote :

We've not noticed this before due to none of the existing blocktype configs that use tinymce having any required field and therefore returning the form after form error

Mahara Bot (dev-mahara) wrote :

Patch for "17.04_STABLE" branch: https://reviews.mahara.org/7990

Reviewed: https://reviews.mahara.org/7990
Committed: https://git.mahara.org/mahara/mahara/commit/12c0a6c681d39af1773bbbe617128c092a519793
Submitter: Robert Lyon (<email address hidden>)
Branch: 17.04_STABLE

commit 12c0a6c681d39af1773bbbe617128c092a519793
Author: Robert Lyon <email address hidden>
Date: Wed Sep 6 11:03:44 2017 +1200

Bug 1715260: Keep tinymce fields on block config form error

behatnotneeded - will be covered by annotation_block.feature

Change-Id: Ibc5652e208ff4d65d2e845678db00ce245e91f63
Signed-off-by: Robert Lyon <email address hidden>

Reviewed: https://reviews.mahara.org/7980
Committed: https://git.mahara.org/mahara/mahara/commit/a6afcf90e8794eac7dc831bd092dfc883ab1098e
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit a6afcf90e8794eac7dc831bd092dfc883ab1098e
Author: Robert Lyon <email address hidden>
Date: Wed Sep 6 11:03:44 2017 +1200

Bug 1715260: Keep tinymce fields on block config form error

behatnotneeded - will be covered by annotation_block.feature

Change-Id: Ibc5652e208ff4d65d2e845678db00ce245e91f63
Signed-off-by: Robert Lyon <email address hidden>

Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/7996
Committed: https://git.mahara.org/mahara/mahara/commit/edb60f893a740efd924937545357bda6fc2f451b
Submitter: Robert Lyon (<email address hidden>)
Branch: 16.10_STABLE

commit edb60f893a740efd924937545357bda6fc2f451b
Author: Robert Lyon <email address hidden>
Date: Wed Sep 6 11:03:44 2017 +1200

Bug 1715260: Keep tinymce fields on block config form error

behatnotneeded - will be covered by annotation_block.feature

Change-Id: Ibc5652e208ff4d65d2e845678db00ce245e91f63
Signed-off-by: Robert Lyon <email address hidden>

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers